Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow select simple object by several points in selection area #367

Closed
ensemenova opened this issue Mar 3, 2021 · 1 comment · Fixed by #381 or #399
Closed

Allow select simple object by several points in selection area #367

ensemenova opened this issue Mar 3, 2021 · 1 comment · Fixed by #381 or #399
Assignees
@AndreiMazol @ensemenova @Svetlana-Asinovskaia
Labels
enhancement

Comments

@ensemenova
Copy link
Contributor

ensemenova commented Mar 3, 2021 •
edited
Loading

Steps to reproduce:

  1. Create different simple object
  2. Try to select them with selection tool

Current behaviour:
They will be selected only when p0 point will turn into selection
Expected Behavior:
When any of points turns into selection from rectangle/ellipse/line it should be selected.
@ensemenova ensemenova added the bug label Mar 3, 2021
@ensemenova ensemenova self-assigned this Mar 10, 2021
@ensemenova ensemenova linked a pull request Mar 10, 2021 that will close this issue
#367 change selection of simple objects #381
Merged
AndreiMazol pushed a commit that referenced this issue Mar 15, 2021
@ensemenova
#367 change selection of simple objects (#381)
92c1da6 
* make selection of simple objects based on reference points

* run prettier

* move ReObject to ts

* clean up code

* clean up code

* update copyright year
AndreiMazol added a commit that referenced this issue Mar 15, 2021
@AndreiMazol
Revert "#367 change selection of simple objects (#381)"
5d3921d 
This reverts commit 92c1da6.
AndreiMazol added a commit that referenced this issue Mar 15, 2021
@AndreiMazol
Revert "#367 change selection of simple objects (#381)" (#394)
9c983f8 
This reverts commit 92c1da6.
@ensemenova ensemenova linked a pull request Mar 16, 2021 that will close this issue
#367 change selection of simple objects + migrate functions to classes #399
Merged
ensemenova added a commit that referenced this issue Mar 16, 2021
@ensemenova
#367 change selection of simple objects + migrate functions to classes (
2cc602e 
#399)

* change selection of simple objects

* move whole package to classes
@Svetlana-Asinovskaia
Copy link
Collaborator

Issue is verified and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@ensemenova ensemenova

@Svetlana-Asinovskaia Svetlana-Asinovskaia

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@AndreiMazol @ensemenova @Svetlana-Asinovskaia