Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No modal windows are opened during R-Group adding #2940

Closed
AleksandraSmolianinova opened this issue Jul 20, 2023 · 1 comment · Fixed by #2942 or #2943
Closed

No modal windows are opened during R-Group adding #2940

AleksandraSmolianinova opened this issue Jul 20, 2023 · 1 comment · Fixed by #2942 or #2943
Assignees
@Iogsotot
Milestone
Ketcher 2.13.0-rc.2

Comments

@AleksandraSmolianinova
Copy link
Collaborator

Steps to Reproduce

  1. Go to Ketcher
  2. Create Benzine
  3. Click on R-Group
  4. Add R-group / R-Group Fragment

Actual behavior
No modal window

Expected behavior
Modal window with R-Group Numbers should open

Ketcher version [e.g. v2.4.2].
Version 2.13.0-rc.1
@Iogsotot Iogsotot assigned Iogsotot and unassigned Nitvex Jul 20, 2023
@Iogsotot Iogsotot mentioned this issue Jul 20, 2023
Closed
@Iogsotot Iogsotot mentioned this issue Jul 20, 2023
Merged
8 tasks
@Nitvex Nitvex linked a pull request Jul 20, 2023 that will close this issue
#2940 – No modal windows are opened during R-Group adding #2942
Merged
8 tasks
Nitvex added a commit that referenced this issue Jul 20, 2023
@Nitvex
#2940 – fix types and console warnings
b2132f1
Nitvex added a commit that referenced this issue Jul 20, 2023
@Iogsotot @dependabot @Nitvex
#2940 – No modal windows are opened during R-Group adding (#2942)
8b9c8d8 
* Bump word-wrap from 1.2.3 to 1.2.4 (#2937)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 2940 - fix: no modal windows are opened during r-group adding

* #2940 – fix types and console warnings

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikita_Vozisov <[email protected]>
Nitvex added a commit that referenced this issue Jul 20, 2023
@Iogsotot @dependabot @Nitvex
Backmerge: #2940 – No modal windows are opened during R-Group adding (#…
8b7443f 
…2942)

* Bump word-wrap from 1.2.3 to 1.2.4 (#2937)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 2940 - fix: no modal windows are opened during r-group adding

* #2940 – fix types and console warnings

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikita_Vozisov <[email protected]>
@Nitvex Nitvex mentioned this issue Jul 20, 2023
Merged
8 tasks
Nitvex added a commit that referenced this issue Jul 21, 2023
@Nitvex @Iogsotot @dependabot
Backmerge: #2940 – No modal windows are opened during R-Group adding (#…
3536ac9 
…2942) (#2943)

* Bump word-wrap from 1.2.3 to 1.2.4 (#2937)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...




* 2940 - fix: no modal windows are opened during r-group adding

* #2940 – fix types and console warnings

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Anna Justus <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 1, 2023

Bug is fixed
2023-08-01_15h51_29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iogsotot Iogsotot

Labels
None yet
Projects
None yet
Milestone
Ketcher 2.13.0-rc.2
4 participants
@Nitvex @Iogsotot @Zhirnoff @AleksandraSmolianinova