Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic load for Miew #2655

Closed
Nitvex opened this issue May 23, 2023 · 1 comment · Fixed by #2661 or #2668
Closed

Add dynamic load for Miew #2655

Nitvex opened this issue May 23, 2023 · 1 comment · Fixed by #2661 or #2668
Assignees
@gairon
Milestone
Ketcher 2.11.0-rc.2

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented May 23, 2023

Background
Miew takes around 1,2-1,5 seconds to load, what negatively impacts page loading speed.

Solution
Add dynamic import for Miew. Miew should be loaded only when user opens 3D preview for structure.
@Nitvex Nitvex added this to the Ketcher 2.12.0-rc.1 milestone May 23, 2023
@Nitvex Nitvex self-assigned this May 23, 2023
@gairon gairon assigned gairon and unassigned Nitvex May 23, 2023
gairon added a commit that referenced this issue May 24, 2023
@gairon
#2655 - Add dynamic load for Miew
06ef358 
* Add lazy loading for miew-react
* Fix build errors if any
@gairon gairon linked a pull request May 24, 2023 that will close this issue
Backmerge: #2655 - Add dynamic load for Miew #2661
Merged
@gairon
Copy link
Contributor

gairon commented May 24, 2023

Performance results:

Before:
Network: image

Performance: image

After:
Network: image
Performance: image

Nitvex pushed a commit that referenced this issue May 24, 2023
@gairon
#2655 - Add dynamic load for Miew (#2661)
3b46db1 
* Add lazy loading for miew-react
* Fix build errors if any
Nitvex pushed a commit that referenced this issue May 24, 2023
@gairon @Nitvex
#2655 - Add dynamic load for Miew (#2661)
2a47912 
* Add lazy loading for miew-react
* Fix build errors if any
@Nitvex Nitvex linked a pull request May 24, 2023 that will close this issue
#2655 - Add dynamic load for Miew (#2661) #2668
Merged
Nitvex added a commit that referenced this issue May 24, 2023
@Nitvex @gairon
#2655 - Add dynamic load for Miew (#2661) (#2668)
229dd0b 
* Add lazy loading for miew-react
* Fix build errors if any

Co-authored-by: gairon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gairon gairon

Labels
None yet
Projects
None yet
Milestone
Ketcher 2.11.0-rc.2
2 participants
@gairon @Nitvex