When you try to add a structure to a canvas with an expanded functional group, an EDIT ABBREVIATION window appears

[Zhirnoff]

Steps to Reproduce

1. Launch Ketcher
2. Open file ketcher.zip
3. Try put it on canvas

Actual behavior
The structure is under mouse cursor and when you try to put it on canvas, EDIT ABBREVIATION window appears.
Note: Perhaps this is due to the fact that the Oxygen atom is located close to the Carbon atom. The Oxygen atom is highlighted and, apparently, when clicked on canvas, editing of the abbreviation is triggered.
Expected behavior
A structure with an expanded Functional Group is added to the canvas

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.5

[kaluginserg]

this bug is affected by changes #2110. Continue investigating.

[kaluginserg]

Found the details.
I checked how Ketcher works now, for a couple of cases.
Screenshot:

A) Whole structure is from the clipboard (PASTE tool triggered). Oxygen and Carbon are not considered to be merged, as there is a space between them.
So the 'Paste' functionality works fine.

B) Whole structure is from the clipboard (PASTE tool triggered). [Incorrect current implementation] Oxygen and Carbon are considered to be merged (there is a highlight for AttachmentPoint).
So the 'Paste' functionality doesn't work well for this case.

The decision, TODO:
We should allow users to put the structure with minor issues (possible attachment points between structures inside Clipboard) on Canvas. But if there is a conflict with the existing structure on Canvas - should be handled in the old way (it must be prevented).

[kaluginserg]

An additional issue found with tool select and moving:

Screen.Recording.2023-05-22.at.17.49.45.mov

Video explanation:
first case: When we move the structure without potential attachment point (merge Oxygen and Carbon) - everything is going as expected, after finishing moving, the structure is the same as before.

second case: When we move the structure with a potential attachment point (merge Oxygen and Carbon) - after completing the move we can see that merge has triggered and the structure has changed.

Decision TODO:
Need to allow a user to move an existing structure with a potential attachment point without triggering a merge inside the structure that has been moving.

[kaluginserg]

An additional issue with the current implementation found with the tool Paste and SGroup:

Screen.Recording.2023-05-23.at.16.21.33.mov

Video explanation:
third case: has two scenarios - one when we open a file and paste SGroup from the file, and also it is valid for cases with simple copy/paste logic.

Decision TODO:
Methinks we should consider this as a bug also.
@KonstantinEpam23 any suggestions?

[KonstantinEpam23]

@kaluginserg Hmm, this is definitely a bug, I believe we might already have a task for this.

@Zhirnoff can you please double-check

[Zhirnoff]

I have looked at this behavior. The user should be able to copy a functional group and attach to a structure atom(CTRL+C then CTRL+V) or cut a functional group and attach to an atom(CTRL+X then CTRL+V)

2023-05-23_21h22_42.mp4