Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DisableQueryElements parameter to disable query elements from extended table #2355

Closed
AlexanderSavelyev opened this issue Mar 15, 2023 · 0 comments · Fixed by #2371
Closed

Add DisableQueryElements parameter to disable query elements from extended table #2355

AlexanderSavelyev opened this issue Mar 15, 2023 · 0 comments · Fixed by #2371
Assignees
@Nitvex @AnastasiiaPlyako
Labels
Priority: High
Milestone
Ketcher 2.10.0-rc.1

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Mar 15, 2023 •
edited by Zhirnoff
Loading

Background
There should be a possibility to disable Extended Table elements.

Solution
Add Ketcher API parameter "disableQueryElements" with an array list of elements
for example
ketcher.setSettings({ disableQueryElements": ["Pol", "CYH", "CXH"] })

It should disable the elements from the Extended Table. See design attachment below
Disabled elements should also show tooltip: "{elementName} is disabled"

** Additional context**
elements_style.zip

#184498615
@AlexanderSavelyev AlexanderSavelyev added this to the Ketcher 2.10.0-rc.1 milestone Mar 15, 2023
@AnastasiiaPlyako AnastasiiaPlyako self-assigned this Mar 15, 2023
AnastasiiaPlyako added a commit that referenced this issue Mar 16, 2023
@AnastasiiaPlyako
#2355 add DisableQueryElements parameter to disable query elements fr…
ba6d3d6 
…om extended table
@AnastasiiaPlyako AnastasiiaPlyako mentioned this issue Mar 16, 2023
Merged
AnastasiiaPlyako added a commit that referenced this issue Mar 17, 2023
@AnastasiiaPlyako
#2355 create separate component for buttom GenSet
b7f071c
AnastasiiaPlyako added a commit that referenced this issue Mar 17, 2023
@AnastasiiaPlyako
#2355 add import in less file
cd78f2d
AnastasiiaPlyako added a commit that referenced this issue Mar 17, 2023
@AnastasiiaPlyako
#2355 add and update copyright
a5b79e2
AnastasiiaPlyako added a commit that referenced this issue Mar 21, 2023
@AnastasiiaPlyako
#2355 update readme
a3a8b6f
KonstantinEpam23 added a commit that referenced this issue Mar 24, 2023
@KonstantinEpam23
#2355 update readme.md
76261a7
AnastasiiaPlyako added a commit that referenced this issue Mar 28, 2023
@AnastasiiaPlyako
#2355 update style accroding design
c5c4585
AnastasiiaPlyako added a commit that referenced this issue Mar 28, 2023
@AnastasiiaPlyako
Merge remote-tracking branch 'origin/#2355-add-DisableQueryElements-p…
8dc9d41 
…arameter-to-disable-query-elements-from-extended-table' into #2355-add-DisableQueryElements-parameter-to-disable-query-elements-from-extended-table
AnastasiiaPlyako added a commit that referenced this issue Mar 31, 2023
@AnastasiiaPlyako
#2355 fix issue to simplifying ButtonGenSet
4ff1ac2
AnastasiiaPlyako added a commit that referenced this issue Mar 31, 2023
@AnastasiiaPlyako
#2355 fix type in ButtonGenSet
e58ae99
KonstantinEpam23 added a commit that referenced this issue Mar 31, 2023
@AnastasiiaPlyako @KonstantinEpam23
#2355 Add DisableQueryElements parameter to disable query elements fr…
eb45cff 
…om extended table (#2371)

* #2355 add DisableQueryElements parameter to disable query elements from extended table

* #2355 create separate component for buttom GenSet

* #2355 add import in less file

* #2355 add and update copyright

* #2355 update readme

* #2355 update readme.md

* #2355 update style accroding design

* #2355 fix issue to simplifying ButtonGenSet

* #2355 fix type in ButtonGenSet

---------

Co-authored-by: Konstantin Levin <[email protected]>
@Zhirnoff Zhirnoff mentioned this issue Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

@AnastasiiaPlyako AnastasiiaPlyako

Labels
Priority: High
Projects
None yet
Milestone
Ketcher 2.10.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2355 Add DisableQueryElements parameter to disable query elements from extended table epam/ketcher
4 participants
@AlexanderSavelyev @Nitvex @Zhirnoff @AnastasiiaPlyako