Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Ketcher into Core and Presentations modules #196

Closed
AndreiMazol opened this issue Dec 21, 2020 · 1 comment · Fixed by #268
Closed

Split Ketcher into Core and Presentations modules #196

AndreiMazol opened this issue Dec 21, 2020 · 1 comment · Fixed by #268
Assignees
@AndreiMazol @Ksanjara @ElenaKlepova
Labels
enhancement

Comments

@AndreiMazol
Copy link
Contributor

AndreiMazol commented Dec 21, 2020 •
edited
Loading

In order to support different presentation layers (React/Angular/Vue & etc) it is necessary to move core functionality into separate module. Every module should be delivered as an independent npm package.

Ketcher_Structure_Diagram

Scope of this task:

  1. Create core package
  2. move shared interfaces into core package
  3. add link to ketcher-react & ketscher-standalone
  4. prepare ketcher-core for publishing to npm
@AndreiMazol AndreiMazol self-assigned this Dec 21, 2020
@AndreiMazol AndreiMazol added this to the Modularity milestone Dec 21, 2020
@AndreiMazol AndreiMazol mentioned this issue Dec 21, 2020
Closed
@AndreiMazol AndreiMazol linked a pull request Jan 26, 2021 that will close this issue
#196 create ketcher-core package #268
Merged
AndreiMazol added a commit that referenced this issue Jan 26, 2021
@AndreiMazol
#196 create ketcher-core package (#268)
cacc433 
* add ketcher-core package folder

* configure re-export inside ketcher-core package

* update signature of RemoteStructServiceProvider

* update dependencies in ketcher-standalone

* update Editor props interface

* make _editor property writable

* mark structservice fields as readonly

* reorder dependencies in package.json

* update tsconfig.json
@ElenaKlepova ElenaKlepova self-assigned this Jan 28, 2021
@ElenaKlepova
Copy link

The issue is verified.

@AndreiMazol AndreiMazol removed this from the Modularity milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@Ksanjara Ksanjara

@ElenaKlepova ElenaKlepova

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#196 create ketcher-core package epam/ketcher
3 participants
@AndreiMazol @Ksanjara @ElenaKlepova