Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw selected structure at mouse cursor after closing Templates window #1954

Closed
Nitvex opened this issue Dec 19, 2022 · 0 comments · Fixed by #2079
Closed

Draw selected structure at mouse cursor after closing Templates window #1954

Nitvex opened this issue Dec 19, 2022 · 0 comments · Fixed by #2079
Assignees
@St-Permiakov @yuleicul @Nitvex
Labels
Priority: High
Milestone
Ketcher 2.9.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Dec 19, 2022 •
edited by Zhirnoff
Loading

At the moment, "Templates Modal" has label "Click to add to canvas", which is not really true. After clicking on a structure, it is not added to canvas and from a user perspective nothing happens. User needs to perform additional click to add a structure on the canvas.

How it should work:

  1. After clicking on structure in "Templates Modal" modal window is closed.
  2. Chosen structure is drawn below the mouse cursor.
  3. The structure must follow the mouse cursor until click is done.
  4. After click, chosen structure is added to canvas.

Additional context:
The desired behaviour may be observed when pasting structure from clipboard.

#184100466
@Nitvex Nitvex added this to the Release 2.7.0 milestone Dec 19, 2022
@Nitvex Nitvex self-assigned this Dec 19, 2022
@vanoprenko vanoprenko changed the title Draw added structure below mouse after choose in Templates Modal Draw selected structure at mouse cursor after closing Templates window Dec 19, 2022
@Nitvex Nitvex added rc.5 and removed rc.4 labels Dec 20, 2022
@yuleicul yuleicul self-assigned this Dec 22, 2022
@vanoprenko vanoprenko removed the rc.6 label Dec 22, 2022
@yuleicul yuleicul mentioned this issue Jan 9, 2023
Closed
@yuleicul yuleicul linked a pull request Jan 9, 2023 that will close this issue
#1954 draw selected structure at mouse cursor after closing templates window #2070
Closed
yuleicul added a commit that referenced this issue Jan 11, 2023
@yuleicul
Make template tool consistent with paste tool
ac2ef83 
Resolves #1954
@yuleicul yuleicul mentioned this issue Jan 11, 2023
Merged
yuleicul added a commit that referenced this issue Jan 18, 2023
@yuleicul
Merge branch 'master' into #1954-draw-selected-structure-at-mouse-cur…
86dea5e 
…sor-as-pasting-does
St-Permiakov pushed a commit that referenced this issue Jan 24, 2023
Merge branch 'master' into #1954-draw-selected-structure-at-mouse-cur…
4292006 
…sor-as-pasting-does
@St-Permiakov St-Permiakov self-assigned this Feb 16, 2023
St-Permiakov pushed a commit that referenced this issue Feb 20, 2023
#1954 - Draw selected structure at mouse cursor after closing Templat…
a2d0c0b 
…es window
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
#1954 - Draw selected structure at mouse cursor after closing Templa…
fb73c1f 
…tes window
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
#1954 - master merge hotfix
d1d874e
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
Merge remote-tracking branch 'origin/master' into #1954-draw-selected…
bd71562 
…-structure-at-mouse-cursor-as-pasting-does
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
Merge branch 'master' into #1954-draw-selected-structure-at-mouse-cur…
e0c3960 
…sor-as-pasting-does
Nitvex added a commit that referenced this issue Mar 9, 2023
@Nitvex
#1954 – fixed tooltip appearance after adding functional group to canvas
cf3fb46
Nitvex added a commit that referenced this issue Mar 9, 2023
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1954-d…
00ec539 
…raw-selected-structure-at-mouse-cursor-as-pasting-does
KonstantinEpam23 pushed a commit that referenced this issue Mar 10, 2023
@yuleicul @Nitvex
#1954 Draw selected structure at mouse cursor after closing Templates…
932733d 
… window (#2079)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

* #1954 - Draw selected structure at mouse cursor after closing Templates window

* #1954 - master merge hotfix

* #1954 – fixed tooltip appearance after adding functional group to canvas

---------

Co-authored-by: Stanislav Permiakov <[email protected]>
Co-authored-by: Stanislav Permiakov <[email protected]>
Co-authored-by: Nikita_Vozisov <[email protected]>
@d-mrzv d-mrzv mentioned this issue Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@St-Permiakov St-Permiakov

@yuleicul yuleicul

@Nitvex Nitvex

Labels
Priority: High
Projects
None yet
Milestone
Ketcher 2.9.0-rc.1
6 participants
@vanoprenko @St-Permiakov @yuleicul @Nitvex @Zhirnoff @KonstantinEpam23