Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s-group data for atom or bond without selection #1887

Closed
AlexanderSavelyev opened this issue Dec 4, 2022 · 0 comments · Fixed by #2080
Closed

Add s-group data for atom or bond without selection #1887

AlexanderSavelyev opened this issue Dec 4, 2022 · 0 comments · Fixed by #2080
Assignees
@epam-nikolai-iakushchenko
Milestone
Release Candidate...

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Dec 4, 2022 •
edited
Loading

Steps to Reproduce

  • Add any structure

  • Scenario 1

  1. Select "S-group" tool
  2. Click on any atom
  • Scenario 2
  1. Select "S-group" tool
  2. Click on any bond
  • Scenario 3
  1. Select "Data S-group" tool
  2. Click on any atom
  • Scenario 4
  1. Select "Data S-group" tool
  2. Click on any bond

Actual behavior
Nothing happens

Expected behavior
Should open "S-group properties" dialog the same as if select atom by selection tool and then click "data Sgroup" (or "s-group") and then click atom
(there should be ability to add s-group information on atom or bond without additional selection

Ketcher version
v 2.6.4
@AlexanderSavelyev AlexanderSavelyev added this to the Release 2.7.0 milestone Dec 4, 2022
@Nitvex Nitvex removed their assignment Dec 12, 2022
@Nitvex Nitvex added rc.5 and removed rc.4 labels Dec 20, 2022
@Nitvex Nitvex added rc.8 and removed rc.7 labels Dec 26, 2022
@epam-nikolai-iakushchenko epam-nikolai-iakushchenko linked a pull request Dec 26, 2022 that will close this issue
#1887 add s group data for atom or bond without selection #2007
Closed
@Nitvex Nitvex modified the milestones: Release 2.7.0, Release 2.8.0 Dec 28, 2022
@Nitvex Nitvex removed the rc.8 label Dec 28, 2022
epam-nikolai-iakushchenko added a commit that referenced this issue Jan 11, 2023
@epam-nikolai-iakushchenko
#1887 Add s-group data for atom or bond without selection
c872fce
Merged
epam-nikolai-iakushchenko added a commit that referenced this issue Jan 11, 2023
@epam-nikolai-iakushchenko
#1887 Add s-group data for atom or bond without selection (#2080)
57ec567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epam-nikolai-iakushchenko epam-nikolai-iakushchenko

Labels
None yet
Projects
None yet
Milestone
Release Candidate 2.8.0-rc.1
5 participants
@AlexanderSavelyev @vanoprenko @Nitvex @epam-nikolai-iakushchenko @KonstantinEpam23