Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra textarea is shown, when Ketcher is not full-screen #1835

Closed
Nitvex opened this issue Nov 11, 2022 · 0 comments · Fixed by #2606
Closed

Extra textarea is shown, when Ketcher is not full-screen #1835

Nitvex opened this issue Nov 11, 2022 · 0 comments · Fixed by #2606
Assignees
@gairon
Milestone
Ketcher 2.11.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Nov 11, 2022

Steps to Reproduce

  1. Use the example application
  2. Limit the width of Ketcher to 50%
  3. Add margin on the left

Also this behaviour may occur, when Ketcher is in modal, although textarea may be invisible (screenshot 2).

Expected behavior
Textarea doesn't need to be shown

Actual behavior
Textarea is shown beyond the Ketcher rendering context.

Screenshots
Screenshot 2022-11-11 at 10 10 13
image

Desktop

  • OS: MacOS
  • Browser: Chrome
  • Version: 106.0.5249.119

Ketcher version.
Ketcher version is 2.6.1

Additional context
The textarea may be done to fix some pasting issue. Please refer:
#1061
https://www.lucidchart.com/techblog/2014/12/02/definitive-guide-copying-pasting-javascript/
#1052
@Nitvex Nitvex added the bug label Nov 11, 2022
@Nitvex Nitvex self-assigned this Nov 11, 2022
@Nitvex Nitvex mentioned this issue Dec 20, 2022
Closed
@KonstantinEpam23 KonstantinEpam23 self-assigned this Dec 20, 2022
gairon added a commit that referenced this issue May 15, 2023
@gairon
#1835 - Extra textarea is shown, when Ketcher is not full-screen
2fe182b 
* Fix style priority to hide textarea visually
@gairon gairon linked a pull request May 15, 2023 that will close this issue
#1835 - Extra textarea is shown, when Ketcher is not full-screen #2606
Merged
@gairon gairon assigned gairon and unassigned Nitvex and KonstantinEpam23 May 16, 2023
gairon added a commit that referenced this issue May 16, 2023
@gairon
#1835 - Extra textarea is shown, when Ketcher is not full-screen
c0ef3e9 
* Fix style priority to hide textarea visually
Nitvex pushed a commit that referenced this issue May 16, 2023
@gairon
#1835 - Extra textarea is shown, when Ketcher is not full-screen (#2606)
1c0ce0e 
* #1835 - Extra textarea is shown, when Ketcher is not full-screen
* Fix style priority to hide textarea visually

* #1835 - Extra textarea is shown, when Ketcher is not full-screen
* Fix style priority to hide textarea visually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gairon gairon

Labels
None yet
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1835 - Extra textarea is shown, when Ketcher is not full-screen epam/ketcher
3 participants
@gairon @Nitvex @KonstantinEpam23