Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode warnings in console #1290

Closed
akolyakov42 opened this issue Feb 25, 2022 · 3 comments · Fixed by #1295, #1313 or #1343
Closed

Strict mode warnings in console #1290

akolyakov42 opened this issue Feb 25, 2022 · 3 comments · Fixed by #1295, #1313 or #1343
Assignees
Milestone

Comments

@akolyakov42
Copy link

akolyakov42 commented Feb 25, 2022

Steps to Reproduce

  1. Launch Ketcher
  2. Open Dev Tools
  3. Switch to Console tab

Case 1: structure appears on canvas
4. Load structure or create it as new project.
5. See strict mode warnings.

Case 2: Layout structure
4. Load structure or create it as new project.
5. Layout canvas by pressing Layout button in upper toolbar
6. See strict mode warnings.

Case 3: S-Groups
4. Load structure or create it as new project.
5. Pick the part of the structure or full structure with Lasso tool.
6. Press S-Group button and click OK in modal window
7. See strict mode warnings

Expected behavior
Console is clear, no warnings

Actual behavior
Console is full of strict mode warnings

Screenshots
Screenshot 2022-02-25 at 18 34 41

User agent

  • Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7)
  • AppleWebKit/537.36 (KHTML, like Gecko)
  • Chrome/98.0.4758.109 Safari/537.36
@akolyakov42
Copy link
Author

akolyakov42 commented Feb 28, 2022

Issue updated by adding cases, in which strict mode warnings appear

@fedorseliankin fedorseliankin linked a pull request Mar 2, 2022 that will close this issue
AndreiMazol pushed a commit that referenced this issue Mar 3, 2022
* fix schema files

* fix 'uniqueItems' and 'required' keywords
@akolyakov42
Copy link
Author

Reopening issue, because warnings still appear when Data S-Groups modal is opened.

Steps to reproduce

  1. Launch Ketcher
  2. Open DevTools and switch to Console tab.
  3. Load structure or create structure on canvas
  4. Press "Data S-Group" button in left toolbar
  5. Select random part of structure
  6. Select the whole structure.
  7. Check Console.

Expected result

  1. Data S-Groups modal is opened.
  2. Console is clear, no warnings.

Actual result

  1. Data S-Groups modal is opened
  2. Warnings appear in Console

Screenshots

Screenshot 2022-03-03 at 23 51 16

@akolyakov42 akolyakov42 reopened this Mar 3, 2022
@fedorseliankin fedorseliankin linked a pull request Mar 7, 2022 that will close this issue
AndreiMazol pushed a commit that referenced this issue Mar 9, 2022
* fix s-group

* fix warnings in SUP and SRU s-group properties

* Update struct-schema.js

* fix label edit warning

* fix sdata warnings
@akolyakov42
Copy link
Author

Discovered more warnings thrown in Data S-Group window

Test steps:
0. Console tab of browser Dev Tools opened

  1. Load or create structure
  2. Select structure with Lasso tool
  3. Press "Data S-Group" (Cmd/Ctrl + G shortcut)
  4. Select "MDLBG_FREAGMENT_RADICALS" from Field name dropdown
  5. See warnings in Console.

Screenshots:
Screenshot 2022-03-21 at 13 17 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment