Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full-screen mode support for Ketcher #1273

Closed
Alena-Guznischeva opened this issue Feb 18, 2022 · 0 comments · Fixed by #1316
Closed

Full-screen mode support for Ketcher #1273

Alena-Guznischeva opened this issue Feb 18, 2022 · 0 comments · Fixed by #1316
Assignees
@AnaMoskvina @akolyakov42
Labels
enhancement
Milestone
Release 2.5.0

Comments

@Alena-Guznischeva
Copy link
Collaborator

Alena-Guznischeva commented Feb 18, 2022 •
edited
Loading

As a developer of the application using Ketcher as a component, I want to add the ability to use Ketcher in full-screen mode to provide a better user experience for my users with the chance to use big Ketcher canvas even for the application with a small place for Ketcher.

Acceptance Criteria:
GIVEN the application that uses Ketcher WHEN the option of the full-screen mode is added THEN Ketcher can be opened in full-screen mode in all the browsers supported

Update on March, 23rd:
Add FullScreen button. Should be placed on the top panel, right top corner. There will be zoom moved near this button to the corner via separate task.
@AndreiMazol AndreiMazol added this to the Release 2.5.0 milestone Feb 22, 2022
@neiloxx neiloxx assigned neiloxx and unassigned AndreiMazol Feb 22, 2022
@AnaMoskvina AnaMoskvina assigned AnaMoskvina and unassigned neiloxx Mar 4, 2022
@AndreiMazol AndreiMazol linked a pull request Mar 23, 2022 that will close this issue
#1273 full screen mode support for ketcher #1316
Merged
AndreiMazol pushed a commit that referenced this issue Mar 29, 2022
@AnaMoskvina
#1273 full screen mode support for ketcher (#1316)
32e0ddf 
* add fullscreen btn for ketcher-react

* fix btn position

* add fullscreen btn to polymer editor

* update snapshot

* fix removing portal

* refactor changes

* update icon and button position

* remove redundant changes

Co-authored-by: Anastasiia Moskvina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaMoskvina AnaMoskvina

@akolyakov42 akolyakov42

Labels
enhancement
Projects
None yet
Milestone
Release 2.5.0
Development

Successfully merging a pull request may close this issue.

#1273 full screen mode support for ketcher epam/ketcher
5 participants
@AndreiMazol @neiloxx @AnaMoskvina @Alena-Guznischeva @akolyakov42