Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlighting API to ketcher-react #1242

Closed
karen-sarkisyan opened this issue Feb 7, 2022 · 1 comment · Fixed by #1252 or #1266
Closed

Add highlighting API to ketcher-react #1242

karen-sarkisyan opened this issue Feb 7, 2022 · 1 comment · Fixed by #1252 or #1266
Assignees
@karen-sarkisyan @akolyakov42
Labels
enhancement
Milestone
Release 2.4.2

Comments

@karen-sarkisyan
Copy link
Contributor

  • An object on ketcher instance with ids of highlighted items on the canvas and highlight's color code
  • Rendering of highlight on the canvas
  • Method to set highlighting by atom and/or bond id with specified color
  • Method to clear highlighting
@karen-sarkisyan karen-sarkisyan self-assigned this Feb 7, 2022
@AndreiMazol AndreiMazol added this to the Release 2.4.2 milestone Feb 9, 2022
@karen-sarkisyan karen-sarkisyan linked a pull request Feb 14, 2022 that will close this issue
#1242 add highlighting #1252
Merged
AndreiMazol pushed a commit that referenced this issue Feb 15, 2022
@karen-sarkisyan
#1242 add highlighting (#1252)
759a4c0 
* Create new highlight entity in struct. In editor, replace previous highlight method with a setHover function

* Create highlight operations and actions

* Modify draw methods for atoms and bonds to display highlight

* Rename highlight to hover across ketcher-core to prevent confusion

* Add highlight update operation and update and append methods for highlighter

* Make create method accept multiple highlights in one call, refactior rendering of highlight

* Hide update and append methods and actions. Rename highlight to highlights, refactor getAll

* Fix code styling
@Svetlana-Asinovskaia
Copy link
Collaborator

Svetlana-Asinovskaia commented Feb 17, 2022 •
edited
Loading

Blank page and errors in console when switching 'Show bonds/atoms Ids' options
2022-02-17_10h01_11

.

@karen-sarkisyan karen-sarkisyan linked a pull request Feb 17, 2022 that will close this issue
#1242 fix atom label rendering #1266
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karen-sarkisyan karen-sarkisyan

@akolyakov42 akolyakov42

Labels
enhancement
Projects
None yet
Milestone
Release 2.4.2
Development

Successfully merging a pull request may close this issue.

#1242 add highlighting epam/ketcher
#1242 fix atom label rendering epam/ketcher
4 participants
@karen-sarkisyan @AndreiMazol @Svetlana-Asinovskaia @akolyakov42