Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure is not deleted by pressing "Delete" button #1096

Closed
AllaZhbanova opened this issue Dec 14, 2021 · 2 comments · Fixed by #1104
Closed

Structure is not deleted by pressing "Delete" button #1096

AllaZhbanova opened this issue Dec 14, 2021 · 2 comments · Fixed by #1104
Assignees
@ElenaOdnoshivkina @AllaZhbanova
Milestone
Release 2.4.0

Comments

@AllaZhbanova
Copy link

Steps to Reproduce
1.Place any structure on the canvas
2. Select the structure
3. Press Delete button on the keyboard

Expected behavior
The structure is deleted

Actual behavior
The structure is not deleted, easer tool is selected

Screenshots

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome Version 93.0.4577.63, Firefox Version 94.0.1, Microsoft Edge Version 93.0.961.47
@AllaZhbanova AllaZhbanova added this to the Release 2.4.0 milestone Dec 14, 2021
@AllaZhbanova AllaZhbanova changed the title Structure is not deleted by selection and pressing "Delete" button Structure is not deleted by pressing "Delete" button Dec 14, 2021
@ElenaOdnoshivkina ElenaOdnoshivkina linked a pull request Dec 16, 2021 that will close this issue
#1096 Structure is not deleted by pressing "Delete" button #1104
Merged
AndreiMazol pushed a commit that referenced this issue Dec 16, 2021
@ElenaOdnoshivkina
#1096 Structure is not deleted by pressing "Delete" button (#1104)
a2831c9 
* adding a flag to save the current tool

* fix replacing atom(s) after pressing hotkey
AndreiMazol added a commit that referenced this issue Dec 16, 2021
@AndreiMazol
Revert "#1096 Structure is not deleted by pressing "Delete" button (#…
ffc39a8 
…1104)"

This reverts commit a2831c9.
AndreiMazol added a commit that referenced this issue Dec 16, 2021
@AndreiMazol
Revert "#1096 Structure is not deleted by pressing "Delete" button (#…
23a5ab5 
…1104)" (#1113)

This reverts commit a2831c9.
@ElenaOdnoshivkina
Copy link
Contributor

The problem is related to refactoring of tools in the task: #1072
For this reason, it was necessary to revert changes made as a pull request: #1114
After reverting the changes, this bug is not reproduced

@ElenaOdnoshivkina ElenaOdnoshivkina mentioned this issue Dec 16, 2021
Closed
@AllaZhbanova
Copy link
Author

fixed, tested v.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaOdnoshivkina ElenaOdnoshivkina

@AllaZhbanova AllaZhbanova

Labels
None yet
Projects
None yet
Milestone
Release 2.4.0
Development

Successfully merging a pull request may close this issue.

#1096 Structure is not deleted by pressing "Delete" button epam/ketcher
3 participants
@AndreiMazol @ElenaOdnoshivkina @AllaZhbanova