feat: Implement write access sharing #377

Oleksii-Klimov · 2024-06-20T09:00:44Z

No description provided.

src/main/java/com/epam/aidial/core/controller/AccessControlBaseController.java

src/main/java/com/epam/aidial/core/security/AccessService.java

src/main/java/com/epam/aidial/core/controller/ShareController.java

src/main/java/com/epam/aidial/core/data/RevokeResourcesRequest.java

src/main/java/com/epam/aidial/core/data/SharedByMeDto.java

src/main/java/com/epam/aidial/core/data/SharedResources.java

src/main/java/com/epam/aidial/core/service/PublicationService.java

src/main/java/com/epam/aidial/core/ProxyContext.java

src/main/java/com/epam/aidial/core/data/SharedByMeDto.java

src/main/java/com/epam/aidial/core/service/RuleService.java

src/main/java/com/epam/aidial/core/service/ShareService.java

src/test/java/com/epam/aidial/core/ResourceBaseTest.java

src/test/java/com/epam/aidial/core/ShareApiTest.java

Maxim-Gadalov · 2024-06-27T15:30:17Z

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-377.nightly-test.deltixhub.io
E2E tests status: failed

# Conflicts: # src/main/java/com/epam/aidial/core/controller/AccessControlBaseController.java # src/main/java/com/epam/aidial/core/controller/ShareController.java

Maxim-Gadalov · 2024-06-27T16:15:56Z

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-377.nightly-test.deltixhub.io
E2E tests status: failed

Maxim-Gadalov · 2024-06-27T16:19:35Z

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-377.nightly-test.deltixhub.io
E2E tests status: failed

Oleksii-Klimov · 2024-06-27T17:00:37Z

/deploy-review

Environment URL: https://chat-ai-dial-core-pr-377.nightly-test.deltixhub.io
E2E tests status: success

Initial implementation.

5e51ea2

Oleksii-Klimov linked an issue Jun 20, 2024 that may be closed by this pull request

Implement write access sharing #376

Closed

Oleksii-Klimov changed the title ~~Implement write access sharing~~ feat: Implement write access sharing Jun 20, 2024

Oleksii-Klimov added 3 commits June 20, 2024 11:00

Update tests.

ce9a1e9

Fix formatting.

9365bf6

Fix flaky tests.

e24c602

astsiapanay reviewed Jun 20, 2024

View reviewed changes

Oleksii-Klimov added 8 commits June 20, 2024 15:37

Fix more tests.

dfc1c77

Missing changes.

c64e330

Revert some changes.

1704166

Add write sharing test.

45fe02a

Implement revoke permissions.

20425f9

Address review comments.

263aec5

Revoke all if no specific permissions.

b0a950d

Minor fixes.

0c065a6

Oleksii-Klimov marked this pull request as ready for review June 21, 2024 10:23

Oleksii-Klimov requested review from artsiomkorzun and Maxim-Gadalov as code owners June 21, 2024 10:23

Oleksii-Klimov added 11 commits June 21, 2024 11:41

Revert some changes.

2535289

Change set to list where makes sense.

3d7ab6c

Make list modifiable.

4b7753c

Optimize shared permissions check.

0526f78

Fix recursive map update.

2e9f073

Small optimization.

71e612a

NPE fix.

9fe3517

Fix condition.

57ee022

Can't create enum set from an empty set.

93d8f0a

Minor fixes.

83d05be

Remove unused imports.

9113378

Oleksii-Klimov self-assigned this Jun 24, 2024

Oleksii-Klimov added 14 commits June 26, 2024 09:12

Minor update.

e0252fb

Clarify names.

df084c6

Fix invitations cleanup.

1385861

Refactor SharedByMeDto.

a5abf82

Fix npe.

e53c670

Fix another npe.

75026b7

Remove permission fetcher.

cbdb29e

Update tests.

8d57f37

Simplify code.

f06ddfd

Filter public resources inside rule service.

31ce59f

Fix npe.

18c9a01

Remove redundant test.

1f644a5

Remove redundant check.

d50fff4

Remove redundant line.

365c009

Maxim-Gadalov reviewed Jun 27, 2024

View reviewed changes

src/test/java/com/epam/aidial/core/ShareApiTest.java Show resolved Hide resolved

Oleksii-Klimov added 3 commits June 27, 2024 16:37

Address review comments.

720bc11

Merge branch 'development' into 376-implement-write-access-sharing

04b2c1a

# Conflicts: # src/main/java/com/epam/aidial/core/controller/AccessControlBaseController.java # src/main/java/com/epam/aidial/core/controller/ShareController.java

Fix typos.

6995705

Oleksii-Klimov added 4 commits June 27, 2024 17:39

Add a test for partial invitation cleanup.

ac4c279

Check if sorting is still needed.

9572eba

Change enum erder.

9fca1c7

Ignore unknown properties for forward compatibility.

8bc7a14

Maxim-Gadalov approved these changes Jun 27, 2024

View reviewed changes

Oleksii-Klimov merged commit 08d1532 into development Jun 27, 2024
7 checks passed

Oleksii-Klimov deleted the 376-implement-write-access-sharing branch June 27, 2024 22:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement write access sharing #377

feat: Implement write access sharing #377

Oleksii-Klimov commented Jun 20, 2024

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Oleksii-Klimov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

feat: Implement write access sharing #377

feat: Implement write access sharing #377

Conversation

Oleksii-Klimov commented Jun 20, 2024

Maxim-Gadalov commented Jun 27, 2024 • edited by ai-dial-actions Loading

Maxim-Gadalov commented Jun 27, 2024 • edited by ai-dial-actions Loading

Maxim-Gadalov commented Jun 27, 2024 • edited by ai-dial-actions Loading

Oleksii-Klimov commented Jun 27, 2024 • edited by ai-dial-actions Loading

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Maxim-Gadalov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading

Oleksii-Klimov commented Jun 27, 2024 •

edited by ai-dial-actions

Loading