-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: workflow to run E2E test on GitHub #161
base: main
Are you sure you want to change the base?
Conversation
actions/e2e_test/action.yml
Outdated
required: true | ||
description: "Comma separated list of usernames for overlay sandbox authentification. The number of users should be equal to number of workers" | ||
type: string | ||
e2e-password: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and for simular secrets: since the recommended usage is like
with:
e2e-admin: ${{ secrets.E2E_ADMIN }}
e2e-username: ${{ secrets.E2E_USERNAME }}
e2e-overlay-username: ${{ secrets.E2E_OVERLAY_USERNAME }}
e2e-password: ${{ secrets.E2E_PASSWORD }}
we can define some defaults like default: ${{ secrets.E2E_PASSWORD }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nepalevov, AFAIK actions cannot access secrets directly. I tried just in case and got syntax error
Error: epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 19, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_ADMIN
Error: epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 22, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_USERNAME
Error: epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 25, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_OVERLAY_USERNAME
Error: epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 28, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_PASSWORD
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 19, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_ADMIN,epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 22, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_USERNAME,epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 25, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_OVERLAY_USERNAME,epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml (Line: 28, Col: 14): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.E2E_PASSWORD
at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load epam/ai-dial-ci/gh-e2e-test/actions/e2e_test/action.yml
This reverts commit 36021e4.
dd454df
to
5287351
Compare
Example: