Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix npm versioning according to semver #741

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

mkviatkovskii
Copy link
Member

No description provided.

@SunFellow
Copy link
Collaborator

I seem the approach to format a version from tags in the repo is wrong. Just the current state of the checked-out commit files matters.

So since package.json in the sources already contains a version, why we can't use it?
If the version of the npm package is different entity then the version in the source and must be unique, then let's think about options:

  • remove version field from package.json or leave a template; so building will set only build number (e.g. the fourth part of the combined version).
  • completely remove/rename package.json from the sources as confusing (duplicating); instead put a template file with input information to be taken for the resulting package.json.

@mkviatkovskii mkviatkovskii merged commit c550fa6 into master May 26, 2022
@mkviatkovskii mkviatkovskii deleted the bugfix/npm-semver branch May 26, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants