Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2747 Incorrect substituent position #2773

Conversation

jblack-mestre
Copy link
Contributor

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@jblack-mestre
Copy link
Contributor Author

This is a problem with superatoms within cdxml files.

For some cdxml files, the nodes within a fragment are given arbitrary coordinates - i.e. coordinates that when rendered look wrong. I'm not sure why this happens; maybe it has to do with chemdraw and how it handles multiple pages. However, instead of using the coordinates of the nodes within the fragment for the superatom, the coordinates are taken from the parent node.

@AliaksandrDziarkach
Copy link
Collaborator

Please use last code version from master - it should fix errors.

@AlexanderSavelyev AlexanderSavelyev merged commit 5e51302 into epam:master Mar 6, 2025
57 checks passed
@AlexanderSavelyev
Copy link
Collaborator

@jblack-mestre merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants