Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1979 Preview: IDT sequence with leading or trailing spaces will not open. #1980

Merged
merged 2 commits into from
May 30, 2024
Merged

#1979 Preview: IDT sequence with leading or trailing spaces will not open. #1980

merged 2 commits into from
May 30, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Refactor IDT parser to skip spaces.
Fix UT.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@AliaksandrDziarkach
#1979 Preview: IDT sequence with leading or trailing spaces will not…
d02d2eb 
… open.

Refactor IDT parser to skip spaces.
Fix UT.
even1024
even1024 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok

@AliaksandrDziarkach AliaksandrDziarkach merged commit b45d44a into master May 30, 2024
74 checks passed
@AliaksandrDziarkach AliaksandrDziarkach deleted the bugfix/1979-idt-space branch May 30, 2024 18:53
This was linked to issues May 30, 2024
Preview: IDT sequence with leading or trailing spaces will not open. #1979
Closed
Preview: Open an IDT file with a "*" character if the "*" is only between nucleotides (RNA presets or unsplit nucleotides) #1978
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AliaksandrDziarkach @even1024