Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System shouldn't allow user to export alternatives ambiguous monomers to IDT (since only mixtures are supported) #2440

Closed
AlexeyGirin opened this issue Sep 30, 2024 · 1 comment · Fixed by #2563 or #2565
Closed

System shouldn't allow user to export alternatives ambiguous monomers to IDT (since only mixtures are supported) #2440

AlexeyGirin opened this issue Sep 30, 2024 · 1 comment · Fixed by #2563 or #2565
Assignees
@AliaksandrDziarkach
Labels
IDT Priority: Medium
Milestone
Indigo-1.25.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Sep 30, 2024 •
edited
Loading

Steps to Reproduce

  1. Toggle to Macro - Flex mode
  2. Load from file: Ambiguous DNA Bases (alternatives).zip
    image
  3. Export canvas to IDT

Actual behavior
System provide the result: NBDHKWY/3Phos/
image

Expected behavior
System throws an error: Alternatives ambiguous monomers on the canvas souldn't be saved to IDT, only mixtures allowed

As per requirement:

For variant monomers (mixed bases) are also supported in IDT notation.

Versions

  • Ketcher Version 2.25.0-rc.5 Build at 2024-09-24; 18:17:25
  • Indigo Toolkit Version 1.24.0-rc.4.0-gdf51dc428-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.71 (Official Build) (64-bit)
  • Win10

Reference issues: #1619
@AlexeyGirin AlexeyGirin added this to the Indigo-1.25.0-rc.1 milestone Sep 30, 2024
AliaksandrDziarkach added a commit that referenced this issue Oct 17, 2024
@AliaksandrDziarkach
#2440 - System shouldn't allow user to export alternatives ambiguous…
f310f04 
… monomers to IDT (since only mixtures are supported)

Fix code. Add UT
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 17, 2024 that will close this issue
#2440 - System shouldn't allow user to export alternatives ambiguous monomers to IDT (since only mixtures are supported) #2563
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Oct 17, 2024
@AliaksandrDziarkach
Backmerge: #2440 - System shouldn't allow user to export alternatives…
9a92c65 
… ambiguous monomers to IDT (since only mixtures are supported)

Backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Oct 17, 2024 that will close this issue
Backmerge: #2440 - System shouldn't allow user to export alternatives ambiguous monomers to IDT (since only mixtures are supported) #2565
Merged
4 tasks
AlexanderSavelyev pushed a commit that referenced this issue Oct 17, 2024
@AliaksandrDziarkach
#2440 - System shouldn't allow user to export alternatives ambiguous…
5e63864 
… monomers to IDT (since only mixtures are supported) (#2563)
AlexanderSavelyev pushed a commit that referenced this issue Oct 17, 2024
@AliaksandrDziarkach
Backmerge: #2440 - System shouldn't allow user to export alternatives…
164a708 
… ambiguous monomers to IDT (since only mixtures are supported) (#2565)
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Oct 18, 2024
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-10-21_19h21_24

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.5]
Indigo version
[Version 1.25.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
IDT Priority: Medium
Projects
None yet
Milestone
Indigo-1.25.0-rc.3
4 participants
@AlexanderSavelyev @AliaksandrDziarkach @AlexeyGirin @Zhirnoff