Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty headers appear when exporting to FASTA #1950

Closed
Zhirnoff opened this issue May 15, 2024 · 1 comment · Fixed by #1951 or #1952
Closed

Empty headers appear when exporting to FASTA #1950

Zhirnoff opened this issue May 15, 2024 · 1 comment · Fixed by #1951 or #1952
Assignees
@even1024
Labels
epic: macromolecules FASTA Bucket: FASTA related issues
Milestone
Indigo-1.20.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Summary
Empty headers appear when exporting to FASTA RNA sequence and RNA-monomers that are not a part of nucleotide or nucleoside

Steps to Reproduce

  1. Open Macro mode
  2. Add any RNA sequence and several RNA-monomers on canvas (see screenshot) or use attached file ketcher (51).zip
  3. Press 'Save' button and select FASTA format

Expected behavior
CHEMs and RNA-monomers that are not a part of nucleotide or nucleoside are ignored during export. As described in #1755

Actual behavior
Empty headers appear when exporting to FASTA

Environment details:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)
  • Indigo Version 1.20.0-rc.2

Attachments
2024-05-15_16h46_59

Additional context
Add any other context about the problem here.
@Zhirnoff Zhirnoff added Bug epic: macromolecules FASTA Bucket: FASTA related issues labels May 15, 2024
@Zhirnoff Zhirnoff added this to the Indigo-1.20.0-rc.3 milestone May 15, 2024
@even1024 even1024 linked a pull request May 15, 2024 that will close this issue
Backmerge: #1950 Empty headers appear when exporting to FASTA #1951
Merged
4 tasks
@even1024 even1024 linked a pull request May 15, 2024 that will close this issue
#1950 Empty headers appear when exporting to FASTA #1952
Merged
7 tasks
even1024 added a commit that referenced this issue May 16, 2024
@even1024
#1950 Empty headers appear when exporting to FASTA (#1952)
8d35248
even1024 added a commit that referenced this issue May 16, 2024
@even1024
Backmerge: #1950 Empty headers appear when exporting to FASTA (#1951)
6a7cd8d
@Zhirnoff
Copy link
Collaborator Author

2024-06-10_15h02_53

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.3]
Indigo version
[Version 1.20.0-rc.3]

@github-project-automation github-project-automation bot moved this to Done in Indigo Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
epic: macromolecules FASTA Bucket: FASTA related issues
Projects
Indigo
Status: Done
Milestone
Indigo-1.20.0-rc.3
2 participants
@even1024 @Zhirnoff