93 increase test coverage #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous implementation.
…` utility function.
…ng from `User.rate` and it is already validated over there.
…working as expected" and removed the overly used word "properly" from test names and doc strings.
…ssary call to `Task.update_schedule_info()` as it is already handled on the `Task` side.
…tor for the `reviews` attribute instead of `_reviews`. * [#93] Removed the unused `Task._validate_start()` method.
Closed
1 task
…ndependent_path()` methods.
…_defaults()` method.
|
Okay so, the test coverage was much lower than what I thought it was (99.96%). Because I was appending the coverage reports while doing my tests, and after updating the code continously for hours, the coverage report data had errorously marking uncovered lines as covered. So, in reality more lines were missing. Anyways, I updated the tests and now the test coverage is really 99.67% . So again, we are practically covering 100% of the code with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test coverage is now 99.94% and the 3 lines of code that the tests are not touching are related to Windows where I'm running the tests in macOS. So, practically Stalker is 100% covered with tests.