Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version.take_name should be renamed to Version.variant_name #69

Closed
2 tasks
eoyilmaz opened this issue Jun 9, 2022 · 0 comments · Fixed by #94
Closed
2 tasks

Version.take_name should be renamed to Version.variant_name #69

eoyilmaz opened this issue Jun 9, 2022 · 0 comments · Fixed by #94
Assignees
@eoyilmaz
Milestone
1.0.0

Comments

@eoyilmaz
Copy link
Owner

eoyilmaz commented Jun 9, 2022 •
edited
Loading

Original Description

As a developer using the Stalker library I want the Version.take_name to be renamed to Version.variant_name to make Stalker follow more modern terminology used in modern systems like USD.

Acceptance Criteria

  1. Rename the Version.take_name attribute to Version.variant_name.
  2. Create Alembic migration for this change.
@eoyilmaz eoyilmaz self-assigned this Jun 9, 2022
@eoyilmaz eoyilmaz added this to the 1.0.0 milestone Dec 8, 2022
@eoyilmaz eoyilmaz changed the title Version.take_name should be renamed to Version.variant Version.take_name should be renamed to Version.variant_name Nov 1, 2024
eoyilmaz added a commit that referenced this issue Nov 1, 2024
@eoyilmaz
[#69] Version.take_name has been renamed to Version.variant_name.
0a2c9c6
@eoyilmaz eoyilmaz linked a pull request Nov 1, 2024 that will close this issue
[#69] Version.take_name has been renamed to Version.variant_name. #94
Merged
eoyilmaz added a commit that referenced this issue Nov 1, 2024
@eoyilmaz
[#69] Parametrized a couple of tests..
9db05da
eoyilmaz added a commit that referenced this issue Nov 1, 2024
@eoyilmaz
[#69] Fixed a Task class test that depends on some default values tha…
23a7b15 
…t are most probably changing during the tests.
eoyilmaz added a commit that referenced this issue Nov 1, 2024
@eoyilmaz
Merge pull request #94 from eoyilmaz/69-versiontake_name-should-be-re…
f9fac7c 
…named-to-versionvariant

[#69] `Version.take_name` has been renamed to `Version.variant_name`.
eoyilmaz added a commit that referenced this issue Nov 11, 2024
@eoyilmaz
[#69] Version.take_name has been renamed to Version.variant_name.
403f2e4
eoyilmaz added a commit that referenced this issue Nov 11, 2024
@eoyilmaz
[#69] Parametrized a couple of tests..
6f8c00d
eoyilmaz added a commit that referenced this issue Nov 11, 2024
@eoyilmaz
[#69] Fixed a Task class test that depends on some default values tha…
586361c 
…t are most probably changing during the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eoyilmaz eoyilmaz

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[#69] Version.take_name has been renamed to Version.variant_name. eoyilmaz/stalker
1 participant
@eoyilmaz