Fix stdio and createprocess calls #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both __file__ lead to DisplayCAL submodule, but the imports are written everywhere as if imported from top level, because that's how py2exe worked.
Python inherited stdio handles seem to not lead to Windows console, while Wtty reads from Windows console and not stdio. Sidestep it by creating new stdio like it used to work on old Python.
Pythonw the console-free version launches without stdio. In certain cases, so can Python - and then sys.stdout is None.
eoyilmaz
force-pushed
the
fix-stdio-createprocess-calls
branch
from
9ce7c1f to
08403fb
Compare
eoyilmaz
merged commit de8c36f
into
eoyilmaz:367-compiled-sucessfully-in-w10-py311-but-createprocess-fails-call-to-dispread-to-measure
eoyilmaz
added a commit
that referenced
this pull request
Sep 27, 2024
…e returned by the `kernel32` library instead of manually setting it to `utf-8` as `cp1252` seems to be working fine, after #383 has been merged. And, simplified a couple of `if` statements that are checking the `stdout.isatty()` value, and updated code formatting.
eoyilmaz
added a commit
that referenced
this pull request
Oct 9, 2024
eoyilmaz
added a commit
that referenced
this pull request
Oct 9, 2024
…e returned by the `kernel32` library instead of manually setting it to `utf-8` as `cp1252` seems to be working fine, after #383 has been merged. And, simplified a couple of `if` statements that are checking the `stdout.isatty()` value, and updated code formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes subprocess launch and communication on Windows and allows the process to be called with pythonw.
Should also fix remaining encoding and perhaps also path issues.