Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EasySwoole] Delete php-stan pattern to fix pipeline #1636

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[EasySwoole] Delete php-stan pattern to fix pipeline #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b58d73
[EasySwoole] Delete php-stan pattern and fix cache issue
voodooism Feb 17, 2025
c116b2d
[EasySwoole] Delete php-stan pattern and fix cache issue
voodooism Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/php_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ jobs:
with:
path: ${{ steps.cache-extensions.outputs.dir }}
key: ${{ steps.cache-extensions.outputs.key }}
restore-keys: ${{ steps.cache-extensions.outputs.key }}

# TODO: Change the version of the action after 2.33 is released
- name: Setup PHP ${{ matrix.php }}
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@297b3cde3c3c3202e03cd5e9b679a74c06f72214
with:
php-version: ${{ matrix.php }}
coverage: ${{ matrix.actions.coverage || 'none' }}
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/split_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ jobs:
with:
path: '${{ steps.cache-extensions.outputs.dir }}'
key: '${{ steps.cache-extensions.outputs.key }}'
restore-keys: '${{ steps.cache-extensions.outputs.key }}'

# TODO: Change the version of the action after 2.33 is released
-
name: 'Setup PHP 8.2'
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@297b3cde3c3c3202e03cd5e9b679a74c06f72214
with:
php-version: 8.2
coverage: none
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/split_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
with:
path: ${{ steps.cache-extensions.outputs.dir }}
key: ${{ steps.cache-extensions.outputs.key }}
restore-keys: ${{ steps.cache-extensions.outputs.key }}

# TODO: Change the version of the action after 2.33 is released
- name: Setup PHP 8.2
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@297b3cde3c3c3202e03cd5e9b679a74c06f72214
with:
php-version: 8.2
coverage: none
Expand Down Expand Up @@ -82,8 +82,9 @@ jobs:
key: ${{ steps.cache-extensions.outputs.key }}
restore-keys: ${{ steps.cache-extensions.outputs.key }}

# TODO: Change the version of the action after 2.33 is released
- name: Setup PHP ${{ matrix.php }}
uses: shivammathur/setup-php@v2
uses: shivammathur/setup-php@297b3cde3c3c3202e03cd5e9b679a74c06f72214
with:
php-version: ${{ matrix.php }}
coverage: pcov
Expand Down
5 changes: 4 additions & 1 deletion packages/EasyAsync/laravel/EasyAsyncServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,10 @@ static function (Container $app): LoggerInterface {
? [EasyLoggingBundleParam::KeyChannel->value => BundleParam::LogChannel->value]
: [];

return $app->make(LoggerInterface::class, $loggerParams);
/** @var \Psr\Log\LoggerInterface $logger */
$logger = $app->make(LoggerInterface::class, $loggerParams);

return $logger;
}
);
}
Expand Down
5 changes: 4 additions & 1 deletion packages/EasySecurity/laravel/EasySecurityServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,10 @@ static function (Container $app): LoggerInterface {
? [EasyLoggingBundleParam::KeyChannel->value => BundleParam::LogChannel->value]
: [];

return $app->make(LoggerInterface::class, $loggerParams);
/** @var \Psr\Log\LoggerInterface $logger */
$logger = $app->make(LoggerInterface::class, $loggerParams);

return $logger;
}
);
}
Expand Down
5 changes: 0 additions & 5 deletions quality/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ parameters:
path: %currentWorkingDirectory%/packages/*/laravel/*ServiceProvider.php
- message: '#Cannot call method .* on mixed#'
path: %currentWorkingDirectory%/packages/*/laravel/*ServiceProvider.php
- message: '#Anonymous function should return .* but returns mixed#'
path: %currentWorkingDirectory%/packages/*/laravel/*ServiceProvider.php
- message: '#Cannot cast mixed to .*#'
path: %currentWorkingDirectory%/packages/*/laravel/*ServiceProvider.php

Expand Down Expand Up @@ -160,9 +158,6 @@ parameters:
- message: '#Strict comparison using \=\=\= between true and false will always evaluate to false#'
path: %currentWorkingDirectory%/packages/EasySwoole/src/Common/Helper/SwooleTableHelper.php

- message: '#Access to undefined constant OpenSwoole\\Constant\:\:SSL#'
path: %currentWorkingDirectory%/packages/EasySwoole/src/Common/Helper/SslCertificateHelper.php

- message: '#Call to an undefined method OpenSwoole\\Core\\Coroutine\\Client\\PDOStatementProxy\:\:.*\(\)#'
path: %currentWorkingDirectory%/packages/EasySwoole/src/Doctrine/Result/DbalResult.php

Expand Down
Loading