Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EasyPagination] More precise results for rows count lower than 100000 #1635

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

alexandrtspl
Copy link
Contributor

  • more precise pagination for rows count < 100000
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...

@eonx-space-to-github-reviews
Copy link

@alexandrtspl alexandrtspl requested a review from akl-95 February 17, 2025 05:05
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch 2 times, most recently from 5cd7a85 to 64ff9a3 Compare February 18, 2025 04:32
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch from 64ff9a3 to c6776da Compare February 18, 2025 04:35
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch from 37cf004 to f0d94f4 Compare February 18, 2025 06:18
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch from f1c1fd3 to f431b4a Compare February 19, 2025 07:32
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch from f431b4a to 31d07d3 Compare February 19, 2025 07:33
alexndlm
alexndlm previously approved these changes Feb 19, 2025
Copy link
Contributor

@alexndlm alexndlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review approved! 👏 Great work.

Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):

  • Protect from Injection attacks
  • Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
  • Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
  • Protect against XSS and CSRF
  • Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
  • Ensure all important errors and business logic cases are handled
  • Ensure forwards and redirects are handled
  • Ensure no sensitive data is exposed and appropriate logging in place as required

See procedure for more details: PROC-010 Secure Coding Practices

alexndlm
alexndlm previously approved these changes Feb 19, 2025
Copy link
Contributor

@alexndlm alexndlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Code review passed.

Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):

  • Protect from Injection attacks
  • Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
  • Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
  • Protect against XSS and CSRF
  • Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
  • Ensure all important errors and business logic cases are handled
  • Ensure forwards and redirects are handled
  • Ensure no sensitive data is exposed and appropriate logging in place as required

See procedure for more details: PROC-010 Secure Coding Practices

alexndlm
alexndlm previously approved these changes Feb 21, 2025
Copy link
Contributor

@alexndlm alexndlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexandrtspl. 👏🏆🎉

Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):

  • Protect from Injection attacks
  • Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
  • Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
  • Protect against XSS and CSRF
  • Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
  • Ensure all important errors and business logic cases are handled
  • Ensure forwards and redirects are handled
  • Ensure no sensitive data is exposed and appropriate logging in place as required

See procedure for more details: PROC-010 Secure Coding Practices

…re/MTCE-357-fix-results-count-when-large-dataset-is-enabled
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch 2 times, most recently from 82e4fef to 2206c05 Compare February 21, 2025 11:25
@alexandrtspl alexandrtspl force-pushed the feature/MTCE-357-fix-results-count-when-large-dataset-is-enabled branch from 2206c05 to 4fa0b78 Compare February 21, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants