[EasyNotification] Update SqsQueueTransport.php to handle FIFO queues #1631
Conversation
mark-fajardo
commented
Jan 27, 2025
•
mark-fajardo
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | PNM-685 |
mark-fajardo
force-pushed
the
feature/PNM-685-update-sqs-queue-transport-to-handle-fifo-queues-new
branch
from
436e7c1 to
a24740c
Compare
mark-fajardo
force-pushed
the
feature/PNM-685-update-sqs-queue-transport-to-handle-fifo-queues-new
branch
from
a24740c to
8885bc2
Compare
|
Code Review in Space: https://eonx.jetbrains.space/p/support/reviews/693/timeline |
There was a problem hiding this comment.
Thanks @mark-fajardo. Nice work! 🎉 Code review complete.
Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):
- Protect from Injection attacks
- Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
- Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
- Protect against XSS and CSRF
- Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
- Ensure all important errors and business logic cases are handled
- Ensure forwards and redirects are handled
- Ensure no sensitive data is exposed and appropriate logging in place as required
See procedure for more details: PROC-010 Secure Coding Practices
| if (\str_ends_with($queueUrl, '.fifo')) { | ||
| $messageDeduplicationId = (string)Uuid::v4(); | ||
| $messageGroupId = (string)Uuid::v4(); | ||
| } |
There was a problem hiding this comment.
I think it's ok not to complicate things in this package as we are the only ones to use it really, but we need to at least required the symfony/uid package in composer so we ensure the Uuid class is available 😄
…: Require symfony/uid
There was a problem hiding this comment.
Well done! Code review passed.
Secure code in this PR has been written to best practice standards and covers the following as a minimum. Please ticket if coded this way (also tick if not relevant to this code change):
- Protect from Injection attacks
- Protect data with proper input validation, and protect against buffer overflows, pointers/shared data
- Protect with appropriate encryption and cryptography (E.g. Appropriate hashing, symmetric encryption used, ciphers) if applicable
- Protect against XSS and CSRF
- Ensure that pages, data access etc, are written with appropriate access control authorisation and authentication requirements
- Ensure all important errors and business logic cases are handled
- Ensure forwards and redirects are handled
- Ensure no sensitive data is exposed and appropriate logging in place as required
See procedure for more details: PROC-010 Secure Coding Practices
