-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about implicit dependency on react-addons-test-utils #228
Merged
lelandrichardson
merged 2 commits into
enzymejs:master
from
thatjessicakelly:warn-about-test-utils
Mar 6, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,15 +62,36 @@ if (REACT013) { | |
return TestUtils.renderIntoDocument(node); | ||
}; | ||
} else { | ||
const ReactDOM = require('react-dom'); | ||
let ReactDOM; | ||
|
||
try { | ||
ReactDOM = require('react-dom'); | ||
} catch (e) { | ||
console.error( | ||
'react-dom is an implicit dependency in order to support [email protected]. ' + | ||
'Please add the appropriate version to your devDependencies. ' + | ||
'See https://github.com/airbnb/enzyme#installation' | ||
); | ||
throw e; | ||
} | ||
|
||
renderToStaticMarkup = require('react-dom/server').renderToStaticMarkup; | ||
findDOMNode = ReactDOM.findDOMNode; | ||
unmountComponentAtNode = ReactDOM.unmountComponentAtNode; | ||
// We require the testutils, but they don't come with 0.14 out of the box, so we | ||
// require them here through this node module. The bummer is that we are not able | ||
// to list this as a dependency in package.json and have 0.13 work properly. | ||
// As a result, right now this is basically an implicit dependency. | ||
TestUtils = require('react-addons-test-utils'); | ||
try { | ||
TestUtils = require('react-addons-test-utils'); | ||
} catch (e) { | ||
console.error( | ||
'react-addons-test-utils is an implicit dependency in order to support [email protected]. ' + | ||
'Please add the appropriate version to your devDependencies. ' + | ||
'See https://github.com/airbnb/enzyme#installation' | ||
); | ||
throw e; | ||
} | ||
|
||
// Shallow rendering changed from 0.13 => 0.14 in such a way that | ||
// 0.14 now does not allow shallow rendering of native DOM elements. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh this should probably
process.exit(1)
rather than rethrowing the errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think error is better. Enzyme can be run in browser-based test runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, very true, this is fine then