-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Extend findWhere null nodes test #1582
[Tests] Extend findWhere null nodes test #1582
Conversation
Test case for issue #1566 without a fix.
+1 on merging this and getting a fix. |
Hmm - I'm not sure I think there's a bug here. I think that it makes sense for However, I think that Thank you - this helped me understand the problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @angelikatyborska, do you agree?
I'm going to merge this. |
This changes the type of text() to be |
@xixixao we don't use or maintain our own types, so please file issues in the appropriate places. |
As requested by @ljharb, this is a failing test case for issue #1566.
expect(spy.callCount).to.equal(3);
- I am not certain if this assertion should expect 3 calls or 4 calls. That depends if thenull
node that is currently passed will be skipped or fixed not to benull
.(Now fixes #1566)