Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ES5 examples to use Enzyme.configure #1156

Closed
wants to merge 1 commit into from
Closed

Update ES5 examples to use Enzyme.configure #1156

wants to merge 1 commit into from

Conversation

andrewb
Copy link

@andrewb andrewb commented Sep 26, 2017 •
edited
Loading

This updates the ES5 examples to use Enzyme.configure({ adapter: new Adapter() }); instead of configure({ adapter: new Adapter() });. Using the current examples IRL will result in ReferenceError: configure is not defined.

ljharb
ljharb approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer all the enzyme instances be lowercased but this is a good change, thanks

@ljharb ljharb added the docs label Sep 26, 2017
@dubbha
Copy link
Contributor

dubbha commented Oct 3, 2017

Fixed in #1219
Synced with #1194

@ljharb
Copy link
Member

ljharb commented Oct 3, 2017

Closed by #1219.

@ljharb ljharb closed this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewb @dubbha @ljharb