-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to remove lifecycleExperimental
option
#1303
Comments
What version are you using? I think we would want to remove that flag more than fix any old compatibility. |
Hi @blainekasten, is detailed in the repo's README: I would expect that shallow's default behavior avoids running those methods that belongs to a mounted component, but per docs, that would be already changed: |
We may need to update the docs. |
That option is the one I found to fix the unit tests after upgrading. Everything is in the repo I added at the beginning. Agree, you may need to update the docs. Thanks. |
lifecycleExperimental
option
@ljharb I can help with this. |
Finishing the work of enzymejs#1303
…React 16 block to contributing doc Fixes enzymejs#1303.
Finishing the work of enzymejs#1303
When
shallow
is used withlifecycleExperimental
option as false,componentDidMount
is called.From shallow docs:
options.lifecycleExperimental: (Boolean [optional]): If set to true, the entire lifecycle (componentDidMount and componentDidUpdate) of the React component is called. The current default value is false with enzyme v2, but the next major version will flip the default value to true.
You can check the issue in this repo with example
Let me know if additional details are needed.
Thanks.
The text was updated successfully, but these errors were encountered: