-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding all our CI jobs to AZP. #827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sobon <[email protected]>
And removing unnecessary statements. Signed-off-by: Jakub Sobon <[email protected]>
And fixing incorrect argument when running format. Signed-off-by: Jakub Sobon <[email protected]>
It is sufficiently large. Also reordering to match the execution order. Signed-off-by: Jakub Sobon <[email protected]>
Also print out the actual number of CPUs used. Signed-off-by: Jakub Sobon <[email protected]>
Signed-off-by: Jakub Sobon <[email protected]>
Signed-off-by: Jakub Sobon <[email protected]>
Signed-off-by: Jakub Sobon <[email protected]>
Enables the coverage test to pass again. Signed-off-by: Jakub Sobon <[email protected]>
Signed-off-by: Jakub Sobon <[email protected]>
Signed-off-by: Jakub Sobon <[email protected]>
This reverts commit 1955124. Signed-off-by: Jakub Sobon <[email protected]>
@tomjzzhang please review and assign back to me once done. |
tomjzzhang
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
75%
to74.2%
. The integration test coverage wasn't executing on CircleCI due to memory limitations. Our coverage dropped despite my attempts to execute this locally before each submission. While I did verify that the tests passed locally, I did not notice that the script is unable to verify the coverage when compiling on RBE. Also removing a TODO linked to Revert Integration Test Coverage percentage. Temporarily Lowered it to get a PR in separately from coverage in follow up PR. #564 which doesn't appear to be relevant anymore.ci/do_ci.sh
so that clang_tidy uses all available CPUs when executing on AZP. Included a logging statement that prints this out in the output for debugging.python_test
that runs all our integration tests to avoid hitting the timeout on test execution.Works on #820.
Signed-off-by: Jakub Sobon [email protected]