Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating references to branch name master->main. #608

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Updating references to branch name master->main. #608

merged 4 commits into from
Jan 26, 2021

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Jan 25, 2021 •
edited
Loading

The branch was renamed recently for multiple repositories in the envoyproxy org.

Signed-off-by: Jakub Sobon [email protected]

@mum4k
Updating references to branch name master->main.
f17d68f 
The branch was renamed recently.

Signed-off-by: Jakub Sobon <[email protected]>
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@mum4k mum4k requested review from oschaaf and wjuan-AFK January 25, 2021 05:11
@mum4k
Copy link
Collaborator Author

mum4k commented Jan 25, 2021

@wjuan-AFK please review and assign back to me once done.

oschaaf
oschaaf approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Out of scope, but one fleeting thought is that it would be cool to have a small utility to check for dead links in scripts, code-level comments and documentation.

@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@wjuan-AFK
Copy link
Contributor

LGTM

@mum4k mum4k merged commit 9448036 into envoyproxy:main Jan 26, 2021
@mum4k mum4k deleted the branch-rename branch January 26, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschaaf oschaaf oschaaf approved these changes

@wjuan-AFK wjuan-AFK wjuan-AFK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mum4k @wjuan-AFK @oschaaf