Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests when running with IPv6. #579

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Fix integration tests when running with IPv6. #579

merged 3 commits into from
Dec 2, 2020

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Dec 1, 2020 •
edited
Loading

We don't run integration tests in IPv6 mode on CI (See #578). As a result some of the test expectations became invalid.

Also:

  • Pytest now displays more logging on test failures including the stderr and stdout of the started nighthawk test server.
  • fixing the default IPv6 address, as per man 3 inet_pton, the address ::/0 isn't valid, while :: is.

Signed-off-by: Jakub Sobon [email protected]

@mum4k mum4k requested review from oschaaf and qqustc December 1, 2020 04:29
@mum4k
Copy link
Collaborator Author

mum4k commented Dec 1, 2020

@qqustc please review and assign back to me once done.

@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Dec 1, 2020
qqustc
qqustc previously approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@qqustc qqustc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oschaaf
oschaaf previously approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question about the change to the wakeup period while polling test server, otherwise LGTM

@mum4k mum4k dismissed stale reviews from oschaaf and qqustc via 6897640 December 2, 2020 03:34
@mum4k mum4k removed the waiting-for-review A PR waiting for a review. label Dec 2, 2020
@mum4k
Copy link
Collaborator Author

mum4k commented Dec 2, 2020

@oschaaf please take another look after the latest changes.

@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Dec 2, 2020
oschaaf
oschaaf approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mum4k mum4k merged commit f5f88e3 into envoyproxy:master Dec 2, 2020
@mum4k mum4k deleted the fix-ipv6-integration branch December 2, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschaaf oschaaf oschaaf approved these changes

@qqustc qqustc qqustc left review comments

Assignees

@mum4k mum4k

Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mum4k @oschaaf @qqustc