CI: make clang-tidy always pass. #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed yestereday, make clang-tidy ignore failures to stop the excessive flaking from being a blocker to merge. Signed-off-by: Otto van der Schaaf <[email protected]>
mum4k
requested changes
Nov 11, 2020
| @@ -34,7 +34,7 @@ function do_test() { | |||
| } | |||
|
|
|||
| function do_clang_tidy() { | |||
| ci/run_clang_tidy.sh | |||
| ci/run_clang_tidy.sh || true | |||
There was a problem hiding this comment.
Can we add a comment here pointing to the issue about a long term fix?
mum4k
added
waiting-for-changes
This was referenced Nov 11, 2020
Signed-off-by: Otto van der Schaaf <[email protected]>
oschaaf
added
waiting-for-review
mum4k
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed yesterday, make clang-tidy ignore failures to stop
the excessive flaking from being a blocker to merge.
This is meant as a temporary stop gap to buy us some time to dig
up the root cause.
Signed-off-by: Otto van der Schaaf [email protected]