Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview doc to include user-specified logging #550

Merged
merged 7 commits into from
Oct 5, 2020

Conversation

jiajunye
Copy link
Contributor

No description provided.

oschaaf
oschaaf previously approved these changes Sep 23, 2020
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise LGTM

Signed-off-by: jiajunye <[email protected]>
oschaaf
oschaaf previously approved these changes Sep 24, 2020
@mum4k mum4k added the waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. label Sep 24, 2020
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit.

@jiajunye jiajunye added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Oct 2, 2020
@mum4k mum4k merged commit 61996df into envoyproxy:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants