Code

Adding config factory#522

Code

Merged

mum4k merged 131 commits intoenvoyproxy:masterenvoyproxy/nighthawk:masterfrom wjuan-AFK:AddingConfigFactorywjuan-AFK/nighthawk:AddingConfigFactoryCopy head branch name to clipboardOct 5, 2020

+668-2

Commits

Commits on Jul 15, 2020

• Adding a multiple path test to confirm that expected paths are hit

  Show description for 99f45d1
  wjuan-AFK

  committed
  99f45d1

  Copy full SHA for 99f45d1

Commits on Jul 17, 2020

• fixing asan problems

  Show description for 075a4cf
  wjuan-AFK

  committed
  075a4cf

  Copy full SHA for 075a4cf

• Fix Format

  Show description for ecbf407
  wjuan-AFK

  committed
  ecbf407

  Copy full SHA for ecbf407

• Removeing unused comments

  Show description for 8fb11b6
  wjuan-AFK

  committed
  8fb11b6

  Copy full SHA for 8fb11b6

• Removing unnecessary invoke calls for cleanliness

  Show description for 032dbba
  wjuan-AFK

  committed
  032dbba

  Copy full SHA for 032dbba

• Merge branch 'master' into RequestSourceUnitTestBenchmarkMultiplePath

  Show description for 953e953
  wjuan-AFK

  committed
  953e953

  Copy full SHA for 953e953

Commits on Jul 20, 2020

• Refactoring test to take in request generator parameter instead of using

  Show description for 6185edb
  wjuan-AFK

  committed
  6185edb

  Copy full SHA for 6185edb

• Changing to pass by reference.

  Show description for cded6ad
  wjuan-AFK

  committed
  cded6ad

  Copy full SHA for cded6ad

• Merge branch 'master' into RequestSourceUnitTestBenchmarkMultiplePath

  Show description for fbfe523
  wjuan-AFK

  committed
  fbfe523

  Copy full SHA for fbfe523

Commits on Jul 21, 2020

• Merge branch 'master' into RequestSourceUnitTestBenchmarkMultiplePath

  Show description for 0d70179
  wjuan-AFK

  committed
  0d70179

  Copy full SHA for 0d70179

• Refactoring per comments in PR. Moving helpers, renaming functions.

  Show description for cdb7efe
  wjuan-AFK

  committed
  cdb7efe

  Copy full SHA for cdb7efe

• Adding comments and renaming testbasicfunctionality for clarity

  Show description for f15bb47
  wjuan-AFK

  committed
  f15bb47

  Copy full SHA for f15bb47

• Consistent unit test naming convention using should. Clarifying comments

  Show description for 59359a2
  wjuan-AFK

  committed
  59359a2

  Copy full SHA for 59359a2

• Fix format

  Show description for f63df91
  wjuan-AFK

  committed
  f63df91

  Copy full SHA for f63df91

Commits on Jul 22, 2020

• Adding a clarifying comment for helper function.

  Show description for 406bd6b
  wjuan-AFK

  committed
  406bd6b

  Copy full SHA for 406bd6b

Commits on Jul 23, 2020

• Fixing typo and other nits

  Show description for f0b697b
  wjuan-AFK

  committed
  f0b697b

  Copy full SHA for f0b697b

• Renaming testBenchmarkClient for clarity

  Show description for 8425e48
  wjuan-AFK

  committed
  8425e48

  Copy full SHA for 8425e48

Commits on Jul 24, 2020

• Replacing Flat hash map with flat hash set for simplicity.

  Show description for fb4f372
  wjuan-AFK

  committed
  fb4f372

  Copy full SHA for fb4f372

• Comment clarification.

  Show description for c6eae6c
  wjuan-AFK

  committed
  c6eae6c

  Copy full SHA for c6eae6c

Commits on Jul 27, 2020

• Small refactor for factory method for more dependency injection.

  Show description for 96ae38b
  wjuan-AFK

  committed
  96ae38b

  Copy full SHA for 96ae38b

• Fix format.

  Show description for b17240f
  wjuan-AFK

  committed
  b17240f

  Copy full SHA for b17240f

• Refactor to inject the requestsourceconstructor.

  Show description for 5c5a146
  wjuan-AFK

  committed
  5c5a146

  Copy full SHA for 5c5a146

• Moving helper functions.

  Show description for 29591ff
  wjuan-AFK

  committed
  29591ff

  Copy full SHA for 29591ff

• Merge branch 'RequestSourceUnitTestBenchmarkMultiplePath' into AddingTestForRequestSourceFactory

  Show description for 7d928a9
  wjuan-AFK

  committed
  7d928a9

  Copy full SHA for 7d928a9

• Fix format.

  Show description for ff82d95
  wjuan-AFK

  committed
  ff82d95

  Copy full SHA for ff82d95

Commits on Jul 28, 2020

• Adding test using the new mock requestsourceconstructor to get remote

  Show description for 98381a4
  wjuan-AFK

  committed
  98381a4

  Copy full SHA for 98381a4

• Fix format.

  Show description for 83ac556
  wjuan-AFK

  committed
  83ac556

  Copy full SHA for 83ac556

• Adding missing request source constructor files.

  Show description for 38c5084
  wjuan-AFK

  committed
  38c5084

  Copy full SHA for 38c5084

• Changing helper functions to anonymous namespace.

  Show description for fa4e285
  wjuan-AFK

  committed
  fa4e285

  Copy full SHA for fa4e285

• Changing to use a nullable pointer instead of reference for clarity.

  Show description for 8551c76
  wjuan-AFK

  committed
  8551c76

  Copy full SHA for 8551c76

• Formatting fixes per PR.

  Show description for 437de5e
  wjuan-AFK

  committed
  437de5e

  Copy full SHA for 437de5e

• Fix format.

  Show description for 6cef87e
  wjuan-AFK

  committed
  6cef87e

  Copy full SHA for 6cef87e

• Merge branch 'master' into RequestSourceUnitTestBenchmarkMultiplePath

  wjuan-AFK

  committed
  c84ba4d

  Copy full SHA for c84ba4d

Commits on Jul 29, 2020

• Fix format after merge.

  Show description for 77d33f9
  wjuan-AFK

  committed
  77d33f9

  Copy full SHA for 77d33f9

• Testing a theory.

  Show description for 73aa686
  wjuan-AFK

  committed
  73aa686

  Copy full SHA for 73aa686

• Fix format.

  Show description for ef77d65
  wjuan-AFK

  committed
  ef77d65

  Copy full SHA for ef77d65

• Merge branch 'RequestSourceUnitTestBenchmarkMultiplePath' into AddingTestForRequestSourceFactory

  Show description for b9182a0
  wjuan-AFK

  committed
  b9182a0

  Copy full SHA for b9182a0

• Merge branch 'master' into RequestSourceUnitTestBenchmarkMultiplePath

  Show description for e38dd80
  wjuan-AFK

  committed
  e38dd80

  Copy full SHA for e38dd80

• Merge branch 'RequestSourceUnitTestBenchmarkMultiplePath' into AddingTestForRequestSourceFactory

  Show description for 21734e4
  wjuan-AFK

  committed
  21734e4

  Copy full SHA for 21734e4

Commits on Aug 17, 2020

• Merge branch 'master' into AddingTestForRequestSourceFactory

  Show description for 7cda9d2
  wjuan-AFK

  committed
  7cda9d2

  Copy full SHA for 7cda9d2

Commits on Aug 19, 2020

• Adding initial protos and stubs.

  Show description for f827aca
  wjuan-AFK

  committed
  f827aca

  Copy full SHA for f827aca

• Adding impl for Dummy request source plugin.

  Show description for d194736
  wjuan-AFK

  committed
  d194736

  Copy full SHA for d194736

• Adding test for request source factory creation.

  Show description for 7820cf9
  wjuan-AFK

  committed
  7820cf9

  Copy full SHA for 7820cf9

• Adding some more protos.

  Show description for bee7805
  wjuan-AFK

  committed
  bee7805

  Copy full SHA for bee7805

• Merge branch 'master' into AddingTestForRequestSourceFactory

  Show description for 3db68ce
  wjuan-AFK

  committed
  3db68ce

  Copy full SHA for 3db68ce

• Merge branch 'AddingTestForRequestSourceFactory' into AddingConfigFactory

  Show description for c0ec4dd
  wjuan-AFK

  committed
  c0ec4dd

  Copy full SHA for c0ec4dd

Commits on Aug 20, 2020

• Fixing mockrequestsourcefactory impacted by the refactor.

  Show description for a1dd3f2
  wjuan-AFK

  committed
  a1dd3f2

  Copy full SHA for a1dd3f2

• Adding more factories to the impl.h

  Show description for 0b25261
  wjuan-AFK

  committed
  0b25261

  Copy full SHA for 0b25261

• Fixing clang tidy.

  Show description for c3fa23c
  wjuan-AFK

  committed
  c3fa23c

  Copy full SHA for c3fa23c

• Updating the impl.cc with a stub for the new factories.

  Show description for 547977e
  wjuan-AFK

  committed
  547977e

  Copy full SHA for 547977e

Commits on Aug 26, 2020

• Adding test for file based request source plugin

  Show description for c300203
  wjuan-AFK

  committed
  c300203

  Copy full SHA for c300203

• Adding test yaml file.

  Show description for 8f4d4d9
  wjuan-AFK

  committed
  8f4d4d9

  Copy full SHA for 8f4d4d9

• Merge branch 'AddingTestForRequestSourceFactory' into AddingConfigFactory

  Show description for 5ae2d51
  wjuan-AFK

  committed
  5ae2d51

  Copy full SHA for 5ae2d51

Commits on Aug 27, 2020

• First try getting requests working.

  Show description for fe74b6d
  wjuan-AFK

  committed
  fe74b6d

  Copy full SHA for fe74b6d

Commits on Sep 1, 2020

• Switching to using multiple requestOptions instead of one.

  Show description for 6d87aea
  wjuan-AFK

  committed
  6d87aea

  Copy full SHA for 6d87aea

Commits on Sep 2, 2020

• Removing unused comments.

  Show description for ca7a0c2
  wjuan-AFK

  committed
  ca7a0c2

  Copy full SHA for ca7a0c2

• Adding api dependency injection.

  Show description for 967e3f8
  wjuan-AFK

  committed
  967e3f8

  Copy full SHA for 967e3f8

Commits on Sep 3, 2020

• Getting the multiple paths parsing into the test.

  Show description for 14b7d79
  wjuan-AFK

  committed
  14b7d79

  Copy full SHA for 14b7d79

• Comment clean up and using loadfromfile instead of reading the file and

  Show description for c4985bb
  wjuan-AFK

  committed
  c4985bb

  Copy full SHA for c4985bb

Commits on Sep 9, 2020

• Switching to using iterators in a vector instead of a smart pointer.

  Show description for 922639a
  wjuan-AFK

  committed
  922639a

  Copy full SHA for 922639a

• Removing unused comments.

  Show description for 81dfece
  wjuan-AFK

  committed
  81dfece

  Copy full SHA for 81dfece

Commits on Sep 10, 2020

• Small cleanup.

  Show description for bf08661
  wjuan-AFK

  committed
  bf08661

  Copy full SHA for bf08661

• Merge branch 'master' into AddingTestForRequestSourceFactory

  Show description for 34900c5
  wjuan-AFK

  committed
  34900c5

  Copy full SHA for 34900c5

• Merge branch 'AddingTestForRequestSourceFactory' into AddingConfigFactory

  Show description for 768fa81
  wjuan-AFK

  committed
  768fa81

  Copy full SHA for 768fa81

• Reverting changes to RequestSourceConstructor.

  Show description for e93bb58
  wjuan-AFK

  committed
  e93bb58

  Copy full SHA for e93bb58

• Removing RPCRequestSourcePlugin

  Show description for f47cbd4
  wjuan-AFK

  committed
  f47cbd4

  Copy full SHA for f47cbd4

• Fix format.

  Show description for 7c5c6b2
  wjuan-AFK

  committed
  7c5c6b2

  Copy full SHA for 7c5c6b2

• Fix format.

  Show description for 1b02cec
  wjuan-AFK

  committed
  1b02cec

  Copy full SHA for 1b02cec

Commits on Sep 11, 2020

• Fixing clang problems.

  Show description for 4d75602
  wjuan-AFK

  committed
  4d75602

  Copy full SHA for 4d75602

• Fixing clang.

  Show description for c74f535
  wjuan-AFK

  committed
  c74f535

  Copy full SHA for c74f535

• Fix format.

  Show description for 9949fb8
  wjuan-AFK

  committed
  9949fb8

  Copy full SHA for 9949fb8

• Fixing clang tidy.

  Show description for fcf10d3
  wjuan-AFK

  committed
  fcf10d3

  Copy full SHA for fcf10d3

• Fix Format

  Show description for fd9744d
  wjuan-AFK

  committed
  fd9744d

  Copy full SHA for fd9744d

Commits on Sep 14, 2020

• Rename requestOptionses to requestOptionsList.

  Show description for 68c1037
  wjuan-AFK

  committed
  68c1037

  Copy full SHA for 68c1037

Commits on Sep 15, 2020

• Renaming proto.

  Show description for 883ee30
  wjuan-AFK

  committed
  883ee30

  Copy full SHA for 883ee30

Commits on Sep 16, 2020

• Updating to take a number of requests.

  Show description for 8c34b25
  wjuan-AFK

  committed
  8c34b25

  Copy full SHA for 8c34b25

• Clean up tests.

  Show description for 6ce7e74
  wjuan-AFK

  committed
  6ce7e74

  Copy full SHA for 6ce7e74

• Changing visibility of RequestSourcePlugin's inheritance.

  Show description for 92927e5
  wjuan-AFK

  committed
  92927e5

  Copy full SHA for 92927e5

• Switching to using lock_guard.

  Show description for a62f2d5
  wjuan-AFK

  committed
  a62f2d5

  Copy full SHA for a62f2d5

• Clean up.

  Show description for 16f89c6
  wjuan-AFK

  committed
  16f89c6

  Copy full SHA for 16f89c6

• Fix Format.

  Show description for f4257e3
  wjuan-AFK

  committed
  f4257e3

  Copy full SHA for f4257e3

Commits on Sep 17, 2020

• Addressing comments on PR. Cleaning up formatting.

  Show description for d075588
  wjuan-AFK

  committed
  d075588

  Copy full SHA for d075588

• Getting rid of RequestSourcePluginPtr, and adding comments.

  Show description for eb10a3b
  wjuan-AFK

  committed
  eb10a3b

  Copy full SHA for eb10a3b

• Removing unnecessary RequestSourcePlugin interface for improved testability and cleanliness.

  Show description for cdbd6bf
  wjuan-AFK

  committed
  cdbd6bf

  Copy full SHA for cdbd6bf

• Fix format

  Show description for 17acc5f
  wjuan-AFK

  committed
  17acc5f

  Copy full SHA for 17acc5f

Commits on Sep 18, 2020

• Cleanup unintentional whitespace.

  Show description for 55a0e62
  wjuan-AFK

  committed
  55a0e62

  Copy full SHA for 55a0e62

• Swapping to exception instead of Release_assert.

  Show description for fa23aad
  wjuan-AFK

  committed
  fa23aad

  Copy full SHA for fa23aad

• Renaming the request_source_plugin to request_source_plugin_config_factory.

  Show description for b8e2447
  wjuan-AFK

  committed
  b8e2447

  Copy full SHA for b8e2447

Commits on Sep 22, 2020

• Using a context struct for extensability.

  Show description for 248f439
  wjuan-AFK

  committed
  248f439

  Copy full SHA for 248f439

• Spacing and comments.

  Show description for 91703b5
  wjuan-AFK

  committed
  91703b5

  Copy full SHA for 91703b5

• Fix format.

  Show description for bbc0c2a
  wjuan-AFK

  committed
  bbc0c2a

  Copy full SHA for bbc0c2a

• Adding test for multiple request sources thread lock.

  Show description for 517c83d
  wjuan-AFK

  committed
  517c83d

  Copy full SHA for 517c83d

• Additional comment

  Show description for c1d0428
  wjuan-AFK

  committed
  c1d0428

  Copy full SHA for c1d0428

• Getting rid of context object because the Register Factory mechanism wouldn't make sense to extend the parameters passed in.

  Show description for bc86c09
  wjuan-AFK

  committed
  bc86c09

  Copy full SHA for bc86c09

Commits on Sep 23, 2020

• Adding option to circumvent file reading.

  Show description for 33e3564
  wjuan-AFK

  committed
  33e3564

  Copy full SHA for 33e3564

• Merge branch 'master' into AddingConfigFactory

  Show description for 338a874
  wjuan-AFK

  committed
  338a874

  Copy full SHA for 338a874

• Fix format.

  Show description for 402ada2
  wjuan-AFK

  committed
  402ada2

  Copy full SHA for 402ada2

• Getting rid of default constructors.

  Show description for 017481f
  wjuan-AFK

  committed
  017481f

  Copy full SHA for 017481f

• Renames for clarity.

  Show description for 3ed43fc
  wjuan-AFK

  committed
  3ed43fc

  Copy full SHA for 3ed43fc

• Fix format.

  Show description for 247b71b
  wjuan-AFK

  committed
  247b71b

  Copy full SHA for 247b71b

Commits on Sep 24, 2020

• Splitting factory off into a separate pr.

  Show description for 171fb2e
  wjuan-AFK

  committed
  171fb2e

  Copy full SHA for 171fb2e

• Proto cleanup/rename

  Show description for 5df83ed
  wjuan-AFK

  committed
  5df83ed

  Copy full SHA for 5df83ed

• Comment cleanup.

  Show description for 0af3ffd
  wjuan-AFK

  committed
  0af3ffd

  Copy full SHA for 0af3ffd

• Proto comments and dummy -> stub clean up.

  Show description for ff90e59
  wjuan-AFK

  committed
  ff90e59

  Copy full SHA for ff90e59

Commits on Sep 28, 2020

• Cleaning up comments

  Show description for e57c05f
  wjuan-AFK

  committed
  e57c05f

  Copy full SHA for e57c05f

• Updating class comments.

  Show description for 55244b0
  wjuan-AFK

  committed
  55244b0

  Copy full SHA for 55244b0

• Refactor to move RequestSourcePlugins to a top level RequestSource folder.

  Show description for c710d37
  wjuan-AFK

  committed
  c710d37

  Copy full SHA for c710d37

• Refactor plugins into separate files.

  Show description for fbb2fdc
  wjuan-AFK

  committed
  fbb2fdc

  Copy full SHA for fbb2fdc

• Fix format.

  Show description for ae0f4a8
  wjuan-AFK

  committed
  ae0f4a8

  Copy full SHA for ae0f4a8

• Merge branch 'master' into AddingConfigFactory

  Show description for e092de0
  wjuan-AFK

  committed
  e092de0

  Copy full SHA for e092de0

• Adding gmock and gtest to check_format so it stops complaining at me.

  Show description for 19b7aa0
  wjuan-AFK

  committed
  19b7aa0

  Copy full SHA for 19b7aa0

Commits on Sep 29, 2020

• Updating to prefix increment, and removing auto.

  Show description for dae3098
  wjuan-AFK

  committed
  dae3098

  Copy full SHA for dae3098

• Removing gmock and gtest from script to avoid conflict. Add Request_source instead.

  Show description for a4b6fb1
  wjuan-AFK

  committed
  a4b6fb1

  Copy full SHA for a4b6fb1

Commits on Sep 30, 2020

• Fixing clang-tidy

  Show description for 55f685e
  wjuan-AFK

  committed
  55f685e

  Copy full SHA for 55f685e

• Using the test value in the stub for better testing.

  Show description for 59c5b94
  wjuan-AFK

  committed
  59c5b94

  Copy full SHA for 59c5b94

• Getting rid of auto. And updating stubplugintest.

  Show description for 2ea0c5e
  wjuan-AFK

  committed
  2ea0c5e

  Copy full SHA for 2ea0c5e

• Further renaming.

  Show description for d40a073
  wjuan-AFK

  committed
  d40a073

  Copy full SHA for d40a073

• Refactor to move plugins into their own libraries and separate files.

  Show description for 7146079
  wjuan-AFK

  committed
  7146079

  Copy full SHA for 7146079

• Moving request_source_plugin_config_factory into its own folder.

  Show description for 7ab1132
  wjuan-AFK

  committed
  7ab1132

  Copy full SHA for 7ab1132

• Refactor to make it testonly.

  Show description for 72c23d0
  wjuan-AFK

  committed
  72c23d0

  Copy full SHA for 72c23d0

Commits on Oct 1, 2020

• Using references instead of making a copy of the option list.

  Show description for 2b1170c
  wjuan-AFK

  committed
  2b1170c

  Copy full SHA for 2b1170c

• Passing in a reference to api instead of apiptr.

  Show description for 9dc3c4b
  wjuan-AFK

  committed
  9dc3c4b

  Copy full SHA for 9dc3c4b

• Renaming request_max to total_requests

  Show description for b555a71
  wjuan-AFK

  committed
  b555a71

  Copy full SHA for b555a71

• Updating comments and removing explicit.

  Show description for 3924eee
  wjuan-AFK

  committed
  3924eee

  Copy full SHA for 3924eee

• Fix format.

  Show description for 75eca07
  wjuan-AFK

  committed
  75eca07

  Copy full SHA for 75eca07

• Merge branch 'master' into AddingConfigFactory

  Show description for 9c93ff9
  wjuan-AFK

  committed
  9c93ff9

  Copy full SHA for 9c93ff9

• Clean up.

  Show description for e2af886
  wjuan-AFK

  committed
  e2af886

  Copy full SHA for e2af886

• Rename FilebasedConfigFactory to OptionListFromFileFactory

  Show description for edae9be
  wjuan-AFK

  committed
  edae9be

  Copy full SHA for edae9be

Commits on Oct 2, 2020

• Improving Comments.

  Show description for 949d731
  wjuan-AFK

  committed
  949d731

  Copy full SHA for 949d731

• Fix format.

  Show description for 59d490f
  wjuan-AFK

  committed
  59d490f

  Copy full SHA for 59d490f

• More comment cleanup.

  Show description for 078329a
  wjuan-AFK

  committed
  078329a

  Copy full SHA for 078329a