Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default LB Policy to Least Request #1901

Merged
merged 1 commit into from
Sep 21, 2023
+117 −1
Merged

Default LB Policy to Least Request #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/authn-single-route-single-match-to-xds.all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
},
"serviceName": "httproute/envoy-gateway-system/backend/rule/0"
},
"lbPolicy": "LEAST_REQUEST",
"name": "httproute/envoy-gateway-system/backend/rule/0",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand All @@ -246,6 +247,7 @@
"connectTimeout": "10s",
"dnsLookupFamily": "V4_ONLY",
"dnsRefreshRate": "30s",
"lbPolicy": "LEAST_REQUEST",
"loadAssignment": {
"clusterName": "raw_githubusercontent_com_443",
"endpoints": [
Expand Down
2 changes: 2 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/authn-single-route-single-match-to-xds.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/envoy-gateway-system/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/envoy-gateway-system/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -142,6 +143,7 @@ xds:
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: raw_githubusercontent_com_443
endpoints:
Expand Down
2 changes: 2 additions & 0 deletions ...rnal/cmd/egctl/testdata/translate/out/authn-single-route-single-match-to-xds.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/envoy-gateway-system/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/envoy-gateway-system/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -24,6 +25,7 @@ xds:
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: raw_githubusercontent_com_443
endpoints:
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/default-resources.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -624,6 +625,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: grpcroute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: grpcroute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -644,6 +646,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tlsroute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tlsroute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -659,6 +662,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tcproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tcproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -674,6 +678,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: udproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: udproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
1 change: 1 addition & 0 deletions internal/cmd/egctl/testdata/translate/out/echo-gateway-api.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/envoy-gateway-system/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/envoy-gateway-system/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@
},
"serviceName": "httproute/default/backend/rule/0"
},
"lbPolicy": "LEAST_REQUEST",
"name": "httproute/default/backend/rule/0",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand All @@ -350,6 +351,7 @@
},
"serviceName": "grpcroute/default/backend/rule/0"
},
"lbPolicy": "LEAST_REQUEST",
"name": "grpcroute/default/backend/rule/0",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand Down Expand Up @@ -379,6 +381,7 @@
},
"serviceName": "tlsroute/default/backend/rule/-1"
},
"lbPolicy": "LEAST_REQUEST",
"name": "tlsroute/default/backend/rule/-1",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand All @@ -400,6 +403,7 @@
},
"serviceName": "tcproute/default/backend/rule/-1"
},
"lbPolicy": "LEAST_REQUEST",
"name": "tcproute/default/backend/rule/-1",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand All @@ -421,6 +425,7 @@
},
"serviceName": "udproute/default/backend/rule/-1"
},
"lbPolicy": "LEAST_REQUEST",
"name": "udproute/default/backend/rule/-1",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -196,6 +197,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: grpcroute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: grpcroute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -216,6 +218,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tlsroute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tlsroute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -231,6 +234,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tcproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tcproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -246,6 +250,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: udproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: udproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
5 changes: 5 additions & 0 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -28,6 +29,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: grpcroute/default/backend/rule/0
lbPolicy: LEAST_REQUEST
name: grpcroute/default/backend/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -48,6 +50,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tlsroute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tlsroute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -63,6 +66,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: tcproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: tcproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -78,6 +82,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: udproute/default/backend/rule/-1
lbPolicy: LEAST_REQUEST
name: udproute/default/backend/rule/-1
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
2 changes: 2 additions & 0 deletions .../egctl/testdata/translate/out/rate-limit-filter-single-route-single-match-to-xds.all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@
},
"serviceName": "httproute/envoy-gateway-system/http-ratelimit/rule/0"
},
"lbPolicy": "LEAST_REQUEST",
"name": "httproute/envoy-gateway-system/http-ratelimit/rule/0",
"outlierDetection": {},
"perConnectionBufferLimitBytes": 32768,
Expand All @@ -246,6 +247,7 @@
"connectTimeout": "10s",
"dnsLookupFamily": "V4_ONLY",
"dnsRefreshRate": "30s",
"lbPolicy": "LEAST_REQUEST",
"loadAssignment": {
"clusterName": "ratelimit_cluster",
"endpoints": [
Expand Down
2 changes: 2 additions & 0 deletions .../egctl/testdata/translate/out/rate-limit-filter-single-route-single-match-to-xds.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/envoy-gateway-system/http-ratelimit/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/envoy-gateway-system/http-ratelimit/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -142,6 +143,7 @@ xds:
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: ratelimit_cluster
endpoints:
Expand Down
2 changes: 2 additions & 0 deletions ...tl/testdata/translate/out/rate-limit-filter-single-route-single-match-to-xds.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ xds:
ads: {}
resourceApiVersion: V3
serviceName: httproute/envoy-gateway-system/http-ratelimit/rule/0
lbPolicy: LEAST_REQUEST
name: httproute/envoy-gateway-system/http-ratelimit/rule/0
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -24,6 +25,7 @@ xds:
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: ratelimit_cluster
endpoints:
Expand Down
2 changes: 1 addition & 1 deletion internal/xds/translator/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func buildXdsCluster(clusterName string, tSocket *corev3.TransportSocket, protoc
cluster := &clusterv3.Cluster{
Name: clusterName,
ConnectTimeout: durationpb.New(10 * time.Second),
LbPolicy: clusterv3.Cluster_ROUND_ROBIN,
LbPolicy: clusterv3.Cluster_LEAST_REQUEST,
DnsLookupFamily: clusterv3.Cluster_V4_ONLY,
CommonLbConfig: &clusterv3.Cluster_CommonLbConfig{
LocalityConfigSpecifier: &clusterv3.Cluster_CommonLbConfig_LocalityWeightedLbConfig_{
Expand Down
1 change: 1 addition & 0 deletions ...al/xds/translator/testdata/out/extension-xds-ir/http-route-extension-filter.clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ads: {}
resourceApiVersion: V3
serviceName: first-route-dest
lbPolicy: LEAST_REQUEST
name: first-route-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
1 change: 1 addition & 0 deletions internal/xds/translator/testdata/out/extension-xds-ir/http-route.clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ads: {}
resourceApiVersion: V3
serviceName: first-route-dest
lbPolicy: LEAST_REQUEST
name: first-route-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
2 changes: 2 additions & 0 deletions internal/xds/translator/testdata/out/xds-ir/accesslog.clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ads: {}
resourceApiVersion: V3
serviceName: direct-route-dest
lbPolicy: LEAST_REQUEST
name: direct-route-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -16,6 +17,7 @@
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: accesslog|otel-collector.default.svc.cluster.local|4317
endpoints:
Expand Down
4 changes: 4 additions & 0 deletions internal/xds/translator/testdata/out/xds-ir/authn-multi-route-multi-provider.clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ads: {}
resourceApiVersion: V3
serviceName: first-route-www.test.com-dest
lbPolicy: LEAST_REQUEST
name: first-route-www.test.com-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -20,6 +21,7 @@
ads: {}
resourceApiVersion: V3
serviceName: second-route-www.test.com-dest
lbPolicy: LEAST_REQUEST
name: second-route-www.test.com-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -29,6 +31,7 @@
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: localhost_443
endpoints:
Expand Down Expand Up @@ -62,6 +65,7 @@
ads: {}
resourceApiVersion: V3
serviceName: "192_168_1_250_8080"
lbPolicy: LEAST_REQUEST
name: "192_168_1_250_8080"
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand Down
3 changes: 3 additions & 0 deletions internal/xds/translator/testdata/out/xds-ir/authn-multi-route-single-provider.clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ads: {}
resourceApiVersion: V3
serviceName: first-route-dest
lbPolicy: LEAST_REQUEST
name: first-route-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -20,6 +21,7 @@
ads: {}
resourceApiVersion: V3
serviceName: second-route-dest
lbPolicy: LEAST_REQUEST
name: second-route-dest
outlierDetection: {}
perConnectionBufferLimitBytes: 32768
Expand All @@ -29,6 +31,7 @@
connectTimeout: 10s
dnsLookupFamily: V4_ONLY
dnsRefreshRate: 30s
lbPolicy: LEAST_REQUEST
loadAssignment:
clusterName: localhost_443
endpoints:
Expand Down
Loading