Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/build: switch to only package level targets in API. #8495

Merged
merged 6 commits into from
Oct 6, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment on maintaining the _lang_BAZEL_RULE_MAPPING defs.
Signed-off-by: Harvey Tuch <[email protected]>
  • Loading branch information
htuch committed Oct 4, 2019
commit 98b6260db7f38c3fd19174dc91ef566ef052a168
6 changes: 6 additions & 0 deletions api/bazel/api_build_system.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ _COMMON_PROTO_DEPS = [
"@com_envoyproxy_protoc_gen_validate//validate:validate_proto",
]

# When we have external proto dependencies, we need to be able to map from the
# proto_library dependency to the relevant {cc,go,py}_library when generating
# the respective language library for some target. If you add a new API
# dependency on some external proto, please provide the mappings here for
# Go/C++/Python.

_GO_BAZEL_RULE_MAPPING = {
"@opencensus_proto//opencensus/proto/trace/v1:trace_proto": "@opencensus_proto//opencensus/proto/trace/v1:trace_proto_go",
"@opencensus_proto//opencensus/proto/trace/v1:trace_config_proto": "@opencensus_proto//opencensus/proto/trace/v1:trace_and_config_proto_go",
Expand Down