Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracer: add CEL sampler to OpenTelemetry #38182

Merged
merged 21 commits into from
Feb 26, 2025
Merged

tracer: add CEL sampler to OpenTelemetry #38182

merged 21 commits into from
Feb 26, 2025

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 24, 2025

Commit Message: add CEL sampler to OpenTelemetry tracer
Additional Description: This is initial PR, there are plans to support request headers in the next step, and any suggestions are welcome. cc @wbpcode
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@zirain
init cel sampler
473ac4e 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from yanavlasov as a code owner January 24, 2025 12:17
@repokitteh-read-only repokitteh-read-only bot added api deps Approval required for changes to Envoy's external dependencies labels Jan 24, 2025
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #38182 was opened by zirain.

see: more, trace.

zirain added 4 commits January 24, 2025 20:46
@zirain
precheck
9d401c5 
Signed-off-by: zirain <[email protected]>
@zirain
precheck
852797d 
Signed-off-by: zirain <[email protected]>
@zirain
precheck
9a3cfa4 
Signed-off-by: zirain <[email protected]>
@zirain
prechecks
360f3fe 
Signed-off-by: zirain <[email protected]>
@moderation
Copy link
Contributor

/lgtm deps

Metadata changes only

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 26, 2025
@alyssawilk
Copy link
Contributor

ping @wbpcode

@adisuissa
Copy link
Contributor

@wbpcode PTAL

wbpcode
wbpcode reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am basically fine to the API. Please ensure the code owners are willing to maintain this new extension. Thanks.

@wbpcode
Copy link
Member

wbpcode commented Feb 5, 2025

@AlexanderEllis @yanavlasov

@wbpcode
Copy link
Member

wbpcode commented Feb 5, 2025

/wait-any

@repokitteh-read-only repokitteh-read-only bot added deps Approval required for changes to Envoy's external dependencies and removed waiting:any labels Feb 6, 2025
yanavlasov
yanavlasov reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait-any

@zirain
required
f9e30d5 
Signed-off-by: zirain <[email protected]>
zirain added 2 commits February 7, 2025 09:01
@zirain
import
113a662 
Signed-off-by: zirain <[email protected]>
@zirain
update
322514a 
Signed-off-by: zirain <[email protected]>
@zirain zirain mentioned this pull request Feb 8, 2025
Open
@zirain zirain requested a review from yanavlasov February 11, 2025 05:46
@yanavlasov
Copy link
Contributor

/wait-any

@zirain
fix format-api
06e531b 
Signed-off-by: zirain <[email protected]>
@zirain
remove unused
311043a 
Signed-off-by: zirain <[email protected]>
@zirain
more test
e7512f1 
Signed-off-by: zirain <[email protected]>
@zirain
fix BUILD
890d56b 
Signed-off-by: zirain <[email protected]>
@zirain
mark as wip
c9f93a3 
Signed-off-by: zirain <[email protected]>
@zirain
format-api
bbdfe45 
Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Member Author

zirain commented Feb 14, 2025

I have no idea why compile_time_options failed. 😞

yanavlasov
yanavlasov requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

@zirain
use cel_expr_parsed
dcbf596 
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from yanavlasov February 17, 2025 13:06
wbpcode
wbpcode reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@KBaichoo
Copy link
Contributor

seems like this is ready for merge as moderation lgtmed deps. @yanavlasov for final pass

@yanavlasov yanavlasov merged commit 856f3de into envoyproxy:main Feb 26, 2025
25 of 26 checks passed
@zirain zirain deleted the cel_sampler branch February 26, 2025 19:49
@zirain zirain mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbpcode wbpcode wbpcode left review comments

@yanavlasov yanavlasov yanavlasov approved these changes

Assignees

@moderation moderation

@yanavlasov yanavlasov

@wbpcode wbpcode

Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zirain @moderation @alyssawilk @adisuissa @wbpcode @yanavlasov @KBaichoo