ext_authz: add logging options #35698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/assign tyxia |
|
/retest |
Signed-off-by: antoniovleonti <[email protected]>
markdroth
reviewed
Aug 15, 2024
|
/lgtm api |
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
|
@tyxia can you PTAL? |
Signed-off-by: antoniovleonti <[email protected]>
|
/retest |
Signed-off-by: antoniovleonti <[email protected]>
tyxia
reviewed
Aug 23, 2024
source/extensions/filters/common/ext_authz/ext_authz_grpc_impl.h
Outdated
Show resolved
Hide resolved
tyxia
reviewed
Aug 23, 2024
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
antoniovleonti
changed the title
markdroth
reviewed
Aug 29, 2024
|
@markdroth @tyxia i think this may be waiting on further review @antoniovleonti if you merge main the current arm fail should be resolved |
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
|
/lgtm api |
Signed-off-by: Antonio V. Leonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
… into authzstatimpl Signed-off-by: antoniovleonti <[email protected]>
tyxia
reviewed
Sep 9, 2024
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
Signed-off-by: antoniovleonti <[email protected]>
|
/retest |
|
@antoniovleonti Looks like retest did not work, please merge main to re-trigger the CI. Thanks! |
Signed-off-by: antoniovleonti <[email protected]>
|
/retest |
|
/retest |
tyxia
approved these changes
Sep 12, 2024
ggreenway
pushed a commit
that referenced
this pull request
Nov 18, 2024
… and logging (#37074) This PR adds field access support for ext_authz filter state object `ExtAuthzLoggingInfo`. It exposes simple fields * latency * bytesSent * bytesReceived This enables usage of ext_authz filter state in access logs, and any filter/logger using CEL after #35698. Signed-off-by: JACQUES Francois <[email protected]>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Nov 18, 2024
… and logging (#37074) This PR adds field access support for ext_authz filter state object `ExtAuthzLoggingInfo`. It exposes simple fields * latency * bytesSent * bytesReceived This enables usage of ext_authz filter state in access logs, and any filter/logger using CEL after envoyproxy/envoy#35698. Signed-off-by: JACQUES Francois <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ 004e6eeaa6b4066f2ba62ca440bbcfb9fb3bc228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: ext_authz: add logging options / stats
Additional Description:
logging_options enables ext_authz to emit per-stream stats through filter state for access logging. The stats emitted depend on the client used.
If envoy GRPC is used, latency, bytes sent, bytes received, upstream host, and cluster info are emitted. Otherwise, only latency is emitted.
If logging_options.filter_metadata is present, ext_authz will also emit the filter metadata in its logging info.
ext authz will only emit stats & and filter metadata if a request is made.
Testing: unit & integration tests
Docs Changes: none
Release Notes: changelog updated
Platform Specific Features: n/a