Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentracing: remove legacy open tracing extension #35418

Merged
merged 2 commits into from
Jul 29, 2024
Merged

opentracing: remove legacy open tracing extension #35418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c355b0
opentracing: remove legacy open tracing extension
alyssawilk Jul 24, 2024
0c3b0c0
hopefully hiding
alyssawilk Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/envoy/config/trace/v3/dynamic_ot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;

// [#protodoc-title: Dynamically loadable OpenTracing tracer]

// DynamicOtConfig is used to dynamically load a tracer from a shared library
// DynamicOtConfig was used to dynamically load a tracer from a shared library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we probably want to make this not-implemented-hide

Copy link
Member

@wbpcode wbpcode Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have provided file level hiding feature and we can hide this file completely. But by the way, why we don't remove this directly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it cant be removed as its part of the api, which is essentially immutable (or at least unremovable)

i dont think its hidden currently (or in this PR)

Copy link
Member

@wbpcode wbpcode Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now any one use the API will only get an error? (Although I have no strong point to that.)

Copy link
Member

@wbpcode wbpcode Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think its hidden currently (or in this PR)

Yeah. I mean we can hide this file completely. This is a optional suggestion to @alyssawilk

Updated that comment to make it more clear

// that implements the `OpenTracing dynamic loading API
// <https://github.com/opentracing/opentracing-cpp>`_.
// [#extension: envoy.tracers.dynamic_ot]
// [#not-implemented-hide:]
message DynamicOtConfig {
option (udpa.annotations.versioning).previous_message_type =
"envoy.config.trace.v2.DynamicOtConfig";
Expand Down
159 changes: 0 additions & 159 deletions bazel/io_opentracing_cpp.patch
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions changelogs/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ date: Pending

behavior_changes:
# *Changes that are expected to cause an incompatibility if applicable; deployment changes are likely required*
- area: tracing
change: |
Removed support for (long deprecated) opentracing. See `issue 27401
<https://github.com/envoyproxy/envoy/issues/27401>`_ for details.

minor_behavior_changes:
# *Changes that may cause incompatibilities for some users, but should not for most*
Expand Down
1 change: 0 additions & 1 deletion source/extensions/extensions_build_config.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ EXTENSIONS = {
# Tracers
#

"envoy.tracers.dynamic_ot": "//source/extensions/tracers/dynamic_ot:config",
"envoy.tracers.datadog": "//source/extensions/tracers/datadog:config",
"envoy.tracers.zipkin": "//source/extensions/tracers/zipkin:config",
"envoy.tracers.opencensus": "//source/extensions/tracers/opencensus:config",
Expand Down
7 changes: 0 additions & 7 deletions source/extensions/extensions_metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,13 +1201,6 @@ envoy.tracers.datadog:
status: stable
type_urls:
- envoy.config.trace.v3.DatadogConfig
envoy.tracers.dynamic_ot:
categories:
- envoy.tracers
security_posture: unknown
status: stable
type_urls:
- envoy.config.trace.v3.DynamicOtConfig
envoy.tracers.opencensus:
categories:
- envoy.tracers
Expand Down
33 changes: 0 additions & 33 deletions source/extensions/tracers/common/ot/BUILD
View file
Open in desktop

This file was deleted.

Loading