Fixed bazel configuration ambiguity for non HTTP3 builds #34483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid ambiguity when building with //bazel:http3=False (on PPC and Windows) this commit adds 2 new config_setting_groups and updates the relevant select() statements. Signed-off-by: Ted Poole <[email protected]>
tedjpoole
force-pushed
the
fix-http3-ppc-windows-ambiguity
branch
from
a10f168 to
d910a0e
Compare
phlax
previously approved these changes
Jun 3, 2024
|
/retest |
|
Sorry but this fix isn't complete. I have another commit coming in a few minutes... |
My first commit didn't really fix anything. This commit completes the fix. Signed-off-by: Ted Poole <[email protected]>
phlax
reviewed
Jun 4, 2024
Signed-off-by: Ted Poole <[email protected]>
|
@phlax Do you know if the test failures on this are known? They don't look related to the changes |
|
yeah - it was fixed already i think - ill push this through |
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid ambiguity when building with
//bazel:http3=False(on PPC and Windows) this commit adds 2 newconfig_setting_groups and updates the relevantselect()statements.Fixes #34482