Begin process of removing singleton use by StringMatcher #32829
Mobile/CC (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Mobile/CC (pr/32829/main@8aac756)
Check started by
Request (pr/32829/main@8aac756)
8aac756 
#32829 merge main@3c84a24
Begin process of removing singleton use by StringMatcher
Commit Message: Begin process of removing singleton use by StringMatcher
This PR temporarily adds two versions of StringMatcherImpl: one that uses the existing singletons, and one that takes a factory context.
Subsequent PRs will gradually convert all uses of StringMatcherImpl to use the factory context. Then the version using singletons will be deleted, along with the code that sets the singletons.
Additional Description: This work is being broken into multiple PRs because otherwise it would be very large and difficult to review.Part of #32792
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
| Key | Value |
|---|---|
| ref | 23a0f9df084f64b795d45ae21bcf247f40a8c643 |
| sha | 8aac756 |
| pr | 32829 |
| base-sha | 3c84a24 |
| actor | @ggreenway |
| message | Begin process of removing singleton use by StringMatcher... |
| started | 1710358351.341222 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 30 |
| patch | 0 |
| dev | true |