quic: handle incoming packets with unknown destination address #32691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Zhang <[email protected]>
|
/retest |
Signed-off-by: Dan Zhang <[email protected]>
| ASSERT(buffer->getRawSlices().size() == 1); | ||
| if (local_address == nullptr) { | ||
| // Quic doesn't know how to handle packets without destination address. Drop them here. |
There was a problem hiding this comment.
nit: The problem is local_address being null, which is "source address" not "destination address", right? (peer_address would be "destination address", I think).
Here, and elsewhere, including the PR description.
There was a problem hiding this comment.
It is the destination address of the incoming packet.
There was a problem hiding this comment.
Oh good lord! Yes, you're right, of course. Sorry!
RyanTheOptimist
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: QUIC client sockets always enable socket options to read destination address of the incoming UDP packets. But in some cases, the address is not returned via the system call, recvmsg or recvmmsg. In such case, Quic connection should drop the packets. And if there are a lot of such packets, the connection should be closed with detailed error sent to the server.
Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a