grpc-mux: refactor c'tor arguments #28781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
Would be nice to use C++20 named args, but given we don't mandate this yet, will review as is, thanks. |
|
PTAL @htuch |
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Oct 22, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Oct 22, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Nov 11, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Dec 2, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Dec 6, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Dec 10, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Dec 12, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Dec 27, 2023
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Jan 23, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Jan 29, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Jan 29, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Jan 29, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to sayboras/proxy
that referenced
this pull request
Jan 29, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/proxy
that referenced
this pull request
Jan 30, 2024
Relates: envoyproxy/envoy#28781 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: grpc-mux: refactor c'tor arguments
Additional Description:
Following #28273 this is a cleanup requested to pass c'tor parameters in a single struct.
Risk Level: low - refactor
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A