Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHV: harmonize check for %00 with legacy path normalization #28727

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

yanavlasov
Copy link
Contributor

@yanavlasov yanavlasov commented Jul 31, 2023

Commit Message:
Make UHV reject requests with %00 sequence in URL path for backward compatibility with the legacy path normalization.

Additional Description:
Refactor common code from some methods.

Risk Level: Low, build flag protected
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #26642

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice!

@yanavlasov yanavlasov merged commit 104e063 into envoyproxy:main Aug 1, 2023
@yanavlasov yanavlasov deleted the uhv-reject-percent-00 branch August 1, 2023 12:06
michaelfinch added a commit to michaelfinch/envoy that referenced this pull request Aug 2, 2023
* main: (144 commits)
  eds: Adding eds caching support to grpc-mux (envoyproxy#28273)
  deps: Bump `build_bazel_rules_apple` -> 2.5.0 (envoyproxy#28747)
  deps: Bump `com_github_cyan4973_xxhash` -> 0.8.2 (envoyproxy#28745)
  deps: Bump `rules_rust` -> 0.26.0 (envoyproxy#28744)
  Revert "Golang: remove HTTP related elements from the golang network … (envoyproxy#28759)
  Golang: remove HTTP related elements from the golang network filter (envoyproxy#28743)
  build(deps): bump jaegertracing/all-in-one from `93ba12f` to `2e210e4` in /examples/shared/jaeger (envoyproxy#28740)
  build(deps): bump pyparsing from 3.0.9 to 3.1.1 in /mobile/docs (envoyproxy#28714)
  deps: Bump `com_github_bufbuild_buf` -> 1.25.0 (envoyproxy#28746)
  Reduce log spam of load shed points if not configured. (envoyproxy#28753)
  [contrib-siporoxy] fix SipTraTest.TraCompleteRetrieveRsp flakyness (envoyproxy#28660)
  Remove implicit deps on fmt_lib (envoyproxy#28662)
  UHV: harmonize check for %00 with legacy path normalization (envoyproxy#28727)
  build(deps): bump redis from `08a82d4` to `b0bdc1a` in /examples/redis (envoyproxy#28713)
  build(deps): bump otel/opentelemetry-collector from `6a76e13` to `dbf77b0` in /examples/opentelemetry (envoyproxy#28741)
  bazel: Switch `exec_tools` -> `tools` (envoyproxy#28729)
  correct some typos for thread_synchronizer.cc and outlier_detection_i… (envoyproxy#28707)
  Cleanup ActiveUdpListenerBase dispatcher call (envoyproxy#28697)
  cleanup: moving checkApiConfigSourceNames to unnamed namespace (envoyproxy#28701)
  ci: Pass through `--nocache_test_results` correctly on scheduled runs (envoyproxy#28690)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants