LEDS: integrating with EDS #18195
Merged
LEDS: integrating with EDS #18195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
@adisuissa thanks. Can we go over this PR at our sync tomorrow? I think I'd benefit from a guided tour given the size. |
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
htuch
suggested changes
Sep 26, 2021
| // Called upon an update to the locality. | ||
| if (validateAllLedsUpdated()) { | ||
| BatchUpdateHelper helper(*this); | ||
| priority_set_.batchHostUpdate(helper); |
There was a problem hiding this comment.
Is the invariant that this is called only once per update and for the last LEDS subscription to update?
There was a problem hiding this comment.
It is called once per LEDS update, and should cover the following cases:
- Before all the locality endpoints of a specific EDS cluster are ready (this will fail the
validateAllLedsUpdated()call, and no actual update will occur. - Whenever a new update for some locality arrives.
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
htuch
suggested changes
Sep 30, 2021
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
@htuch thanks for the comments. Should be ready for another pass. |
|
FWIW I chatted with Adi offline and the plan is to land docs / release notes in a followup PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: LEDS: integrating with EDS
Additional Description:
Allows the usage of the LEDS protocol with EDS messages.
Most of the changes are for the integration tests.
One key question is whether we can minimize the amount of memory used when LEDS isn't used.
Risk Level: Medium - Impact EDS behavior.
Testing: Many integration tests.
Docs Changes: TBD.
Release Notes: TBD.
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg [email protected]