thrift proxy: move more of Router into RequestOwner #17376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is PR 2/4 towards implementing shadow requests for thrift. This moves all the stats into the common RequestOwner interface so that they can be reused. The next, similar sized, PR will decouple UpstreamRequest from the Router so that it can be reused by the upcoming ShadowRequest class. The final PR should introduce the ShadowWriter and ShadowRequest classes and make use of RequestOwner to tie them together. Signed-off-by: Raul Gutierrez Segales <[email protected]>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
This is PR 2/4 towards implementing shadow requests for thrift. This moves all the stats into the common RequestOwner interface so that they can be reused. The next, similar sized, PR will decouple UpstreamRequest from the Router so that it can be reused by the upcoming ShadowRequest class. The final PR should introduce the ShadowWriter and ShadowRequest classes and make use of RequestOwner to tie them together. Risk Level: low, refactor Testing: existing tests pass Docs Changes: n/a Release Notes: n/a Signed-off-by: Raul Gutierrez Segales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 2/4 towards implementing shadow requests for thrift.
This moves all the stats into the common RequestOwner interface so that
they can be reused. The next, similar sized, PR will decouple
UpstreamRequest from the Router so that it can be reused by the upcoming
ShadowRequest class.
The final PR should introduce the ShadowWriter and ShadowRequest classes
and make use of RequestOwner to tie them together.
Signed-off-by: Raul Gutierrez Segales [email protected]