Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

wrowe · 2021-04-16T21:48:21Z

Commit Message: Windows-specific filegroup to capture envoy-static.pdb output file from opt build
Additional Description:

Adds a windows-specific envoy-static-exe target that adds the pdb_file group to the default group
Move the pdb output into the debug image

See bazelbuild/rules_cc#94 for details

Signed-off-by: William A Rowe Jr [email protected]

Risk Level: low
Testing: local msvc + clang-cl in process across opt/dbg/fastbuild
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: Windows target only

wrowe · 2021-04-16T21:49:19Z

Lots of tests yet to complete - offering this up to @envoyproxy/windows-dev for early access

htuch · 2021-04-18T17:50:37Z

/assign-from @envoyproxy/windows-dev

repokitteh-read-only · 2021-04-18T17:50:40Z

@envoyproxy/windows-dev assignee is @sunjayBhatia

🐱

Caused by: a #16043 (comment) was created by @htuch.

see: more, trace.

wrowe · 2021-04-19T06:29:38Z

Pleased to report this succeeds agnostically in dbg and fastbuild builds (where pdb is captured) as well as opt (where pdb is discarded by default.) @davinci26 I see you are also working on images and mentioned azure, so please have a look.

In terms of distinct packages from Windows for only the .exe, or combo .exe+.pdb, I am wondering whether .zip files make more sense for distribution (as Extract-Archive is baked in to PowerShell), but that can even be a separate discussion, this workaround mentioned in bazelbuild/rules_cc#94 solves (and could be documented, at the bazel project.)

sunjayBhatia · 2021-04-19T13:29:41Z

Looks like theres still an issue with getting the .exe output with this change: https://dev.azure.com/cncf/envoy/_build/results?buildId=72410&view=logs&j=b840a642-5ff3-5357-2e4b-e06e40b0cffd&t=67965174-5100-5631-9dc0-68b9f0aacb53&l=903

wrowe · 2021-04-19T17:36:30Z

Looks like theres still an issue with getting the .exe output

Let's try stacking cc_binary+filegroup, since there appears to be no way to solve this in a single filegroup, especially without confusing build source refs.

wrowe · 2021-04-20T00:59:50Z

No behaviors working as-expected, I've re-escalated to bazel team.

wrowe · 2021-04-20T14:52:10Z

Pleased to report this succeeds agnostically in dbg and fastbuild builds

Strike my previous report. We are not going to be able to trust local builds, as we work out the right fix, we will have to bump through 6 CI passes (fastbuild dbg opt against msvc, clang-cl) before declaring it resolved.

wrowe · 2021-04-27T03:04:43Z

The dbg build fails in a predictable ways (Release - msvc / clang-cl);

 //test/extensions/filters/http/lua:lua_filter_test                       FAILED in 2 out of 2 in 24.3s
 //test/server:filter_chain_benchmark_test_benchmark_test                 FAILED in 2 out of 2 in 9.5s
 //test/integration:integration_test                                       FLAKY, failed in 1 out of 3 in 303.2s

 //test/extensions/filters/http/lua:lua_filter_test                       FAILED in 2 out of 2 in 32.8s
 //test/server:filter_chain_benchmark_test_benchmark_test                 FAILED in 2 out of 2 in 11.1s
 //test/extensions/filters/http/wasm:wasm_filter_test                      FLAKY, failed in 1 out of 51 in 11.6s

The fastbuild build fails similarly (Release - msvc / clang-cl);

 //test/server:server_test                                               TIMEOUT in 2 out of 2 in 304.0s
 //test/extensions/filters/http/lua:lua_filter_test                       FAILED in 2 out of 2 in 17.9s
 //test/extensions/http/header_formatters/preserve_case:preserve_case_formatter_integration_test FAILED in 2 out of 2 in 5.2s
 //test/extensions/transport_sockets/tls/cert_validator/spiffe:spiffe_validator_integration_test FAILED in 2 out of 2 in 5.7s
 //test/integration:tcp_proxy_integration_test                             FLAKY, failed in 1 out of 3 in 303.5s
 //test/integration:multiplexed_integration_test                          FAILED in 2 out of 5 in 32.1s

 //test/server:server_test                                               TIMEOUT in 2 out of 2 in 303.9s
 //test/extensions/filters/http/lua:lua_filter_test                       FAILED in 2 out of 2 in 14.7s
 //test/extensions/http/header_formatters/preserve_case:preserve_case_formatter_integration_test FAILED in 2 out of 2 in 5.9s
 //test/extensions/transport_sockets/tls/cert_validator/spiffe:spiffe_validator_integration_test FAILED in 2 out of 2 in 5.1s
 //test/integration:tcp_proxy_integration_test                             FLAKY, failed in 1 out of 3 in 303.1s
 //test/integration:multiplexed_integration_test                          FAILED in 3 out of 6 in 29.3s

The code is expected to behave differently when not optimized, but the .exe and .pdb files were both emitted in all cases, so this workaround is confirmed to not be disruptive. Reverting to opt for review.

repokitteh-read-only · 2021-05-10T14:49:07Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16043 was synchronize by wrowe.

see: more, trace.

wrowe · 2021-05-24T18:27:28Z

Can't take this any further, we will have to rebuild the toolchains, and must have a tag on bazel inclusive of this change... so it's on pause.

wrowe · 2021-06-04T00:32:22Z

The bazel fix has made it into 5.0.0-pre.20210510.2 (and .2.2) but did not make it into 4.1.0 and is not yet present in a 4.1.x candidate, if one is eventually created.

wrowe · 2021-06-09T14:46:08Z

This continues to be blocked on bazel release 4.2 for commit bazelbuild/bazel@6dc941e and needs a corresponding rules_cc bump.

github-actions · 2021-07-09T16:01:03Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Yan Avlasov <[email protected]>

…tput See bazelbuild/rules_cc#94 for details Use generate_pdb_file feature to capture pdb from envoy-static.exe - Introduces features list arg to envoy_cc_binary - Toggles the feature only for the windows opt case in the envoy-static target - Capture the resulting envoy-static.pdb output Signed-off-by: William A Rowe Jr <[email protected]>

Drops clang-cl which is presently broken Signed-off-by: William A Rowe Jr <[email protected]>

wrowe · 2021-10-06T18:42:38Z

With the updated bazel-toolchain images provisioned and bazel 4.2.1 out, this is now ready for review.

davinci26

Awesome, thanks for driving this across so many layers. One small question

ci/windows_ci_steps.sh

davinci26 · 2021-10-07T16:21:56Z

I have approved so I will defer to @lizan for the final review/merge

davinci26 · 2021-10-12T18:31:17Z

This could be merged but since its windows PR, I would also like one reviewer outside of the windows devs.

Lizan is OOO for KubeCon this week.

/assign-from @envoyproxy/senior-maintainers (edit: after my trick failed, I assigned it to Matt)

repokitteh-read-only · 2021-10-12T18:31:21Z

@envoyproxy/senior-maintainers assignee is @lizan

🐱

Caused by: a #16043 (comment) was created by @davinci26.

see: more, trace.

wrowe marked this pull request as draft April 16, 2021 21:48

repokitteh-read-only bot assigned sunjayBhatia Apr 18, 2021

wrowe marked this pull request as ready for review April 19, 2021 06:26

wrowe changed the title ~~Experimental filegroup to capture opt build pdb output~~ Windows-specific filegroup to capture envoy-static.pdb output file from opt build Apr 19, 2021

wrowe mentioned this pull request Apr 19, 2021

Windows: Publish envoy-windows-debug container #14265

Closed

wrowe marked this pull request as draft April 20, 2021 00:59

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 10, 2021

wrowe mentioned this pull request May 10, 2021

Windows feature generate_pdb_file should be applicable to opt builds bazelbuild/rules_cc#94

Closed

wrowe force-pushed the pdb-hack branch from 44ccea7 to ab05758 Compare May 19, 2021 19:59

wrowe added area/build area/windows waiting labels May 21, 2021

wrowe mentioned this pull request May 27, 2021

Evaluate a bazel build patch in CI #16701

Closed

github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 9, 2021

wrowe added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Jul 13, 2021

yanavlasov and others added 4 commits October 4, 2021 11:30

Update bazel to 4.2.1

5ba05d9

Signed-off-by: Yan Avlasov <[email protected]>

Update toolchains

9a29f89

Signed-off-by: Yan Avlasov <[email protected]>

Use correct build image sha

9f79431

Signed-off-by: Yan Avlasov <[email protected]>

wrowe force-pushed the pdb-hack branch from d25db3f to 4c50b57 Compare October 4, 2021 16:30

repokitteh-read-only bot removed the waiting label Oct 4, 2021

Merge remote-tracking branch 'origin/main' into pdb-hack

9e3c247

Drops clang-cl which is presently broken Signed-off-by: William A Rowe Jr <[email protected]>

wrowe unassigned sunjayBhatia Oct 6, 2021

wrowe marked this pull request as ready for review October 6, 2021 18:41

wrowe requested review from lizan and davinci26 October 6, 2021 18:41

davinci26 reviewed Oct 6, 2021

View reviewed changes

ci/windows_ci_steps.sh Show resolved Hide resolved

davinci26 approved these changes Oct 6, 2021

View reviewed changes

mattklein123 assigned davinci26 Oct 7, 2021

davinci26 assigned lizan Oct 7, 2021

davinci26 assigned mattklein123 Oct 12, 2021

wrowe requested a review from mattklein123 October 12, 2021 20:11

mattklein123 merged commit 6252a1e into envoyproxy:main Oct 12, 2021

wrowe deleted the pdb-hack branch October 12, 2021 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

wrowe commented Apr 16, 2021 •

edited

Loading

wrowe commented Apr 16, 2021

htuch commented Apr 18, 2021

repokitteh-read-only bot commented Apr 18, 2021

wrowe commented Apr 19, 2021

sunjayBhatia commented Apr 19, 2021 •

edited

Loading

wrowe commented Apr 19, 2021

wrowe commented Apr 20, 2021

wrowe commented Apr 20, 2021

wrowe commented Apr 27, 2021 •

edited

Loading

repokitteh-read-only bot commented May 10, 2021

wrowe commented May 24, 2021

wrowe commented Jun 4, 2021

wrowe commented Jun 9, 2021

github-actions bot commented Jul 9, 2021

wrowe commented Oct 6, 2021

davinci26 left a comment

davinci26 commented Oct 7, 2021

davinci26 commented Oct 12, 2021 •

edited

Loading

repokitteh-read-only bot commented Oct 12, 2021

Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

Windows-specific filegroup to capture envoy-static.pdb output file from opt build #16043

Conversation

wrowe commented Apr 16, 2021 • edited Loading

wrowe commented Apr 16, 2021

htuch commented Apr 18, 2021

repokitteh-read-only bot commented Apr 18, 2021

wrowe commented Apr 19, 2021

sunjayBhatia commented Apr 19, 2021 • edited Loading

wrowe commented Apr 19, 2021

wrowe commented Apr 20, 2021

wrowe commented Apr 20, 2021

wrowe commented Apr 27, 2021 • edited Loading

repokitteh-read-only bot commented May 10, 2021

wrowe commented May 24, 2021

wrowe commented Jun 4, 2021

wrowe commented Jun 9, 2021

github-actions bot commented Jul 9, 2021

wrowe commented Oct 6, 2021

davinci26 left a comment

Choose a reason for hiding this comment

davinci26 commented Oct 7, 2021

davinci26 commented Oct 12, 2021 • edited Loading

repokitteh-read-only bot commented Oct 12, 2021

wrowe commented Apr 16, 2021 •

edited

Loading

sunjayBhatia commented Apr 19, 2021 •

edited

Loading

wrowe commented Apr 27, 2021 •

edited

Loading

davinci26 commented Oct 12, 2021 •

edited

Loading