dubbo: support wildcard match for dubbo interface #15121
Conversation
Signed-off-by: wbpcode <[email protected]>
|
@zyfjeff, Would you mind help me to take the first pass? Thanks! |
wbpcode
changed the title
| @@ -129,14 +129,50 @@ class MethodRouteEntryImpl : public RouteEntryImplBase { | |||
|
|
|||
| class SingleRouteMatcherImpl : public RouteMatcher, public Logger::Loggable<Logger::Id::dubbo> { | |||
| public: | |||
| class InterfaceMatcher { | |||
There was a problem hiding this comment.
https://github.com/envoyproxy/envoy/blob/main/source/extensions/tracers/xray/util.cc#L26
Is it possible to reuse this existing implementation? Just add case-sensitive settings on top of this.
There was a problem hiding this comment.
We also need to add some comments in the proto file to indicate that the interface uses wildcards to match.
There was a problem hiding this comment.
Since we only support the same prefix or suffix match as the HTTP virtual host, I don't think it's necessary to use such a relatively complex implementation in xray. The current implementation should have better performance.
There was a problem hiding this comment.
I will add some new comments.
|
/assign @zyfjeff |
Signed-off-by: wbpcode <[email protected]>
Signed-off-by: wbpcode <[email protected]>
|
@htuch When you have time, could you please review the API update? This PR does not directly modify any of the APIs, but extends the meaning and functionality of an existing configuration. |
Signed-off-by: wbpcode [email protected]
Commit Message: support wildcard match for dubbo interface
Additional Description:
Support wildcard match、suffix match and prefix match for dubbo interface name. Check #14765 get more information.
Risk Level: Low
Testing: Unit Test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]